Skip to content

[V1] fix(renderer): do not fail when using or #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2020
Merged

[V1] fix(renderer): do not fail when using or #407

merged 1 commit into from
Apr 1, 2020

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Mar 30, 2020

backport of #405

@rvsia rvsia added bug Something isn't working renderer React form renderer PR V1 backports for V1 labels Mar 30, 2020
@rvsia rvsia requested a review from Hyperkid123 March 30, 2020 11:25
@rvsia rvsia changed the base branch from master to v1 March 30, 2020 11:25
@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #407 into v1 will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               v1     #407   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         100      100           
  Lines        2035     2035           
  Branches      673      673           
=======================================
  Hits         1865     1865           
  Misses        170      170
Impacted Files Coverage Δ
...m-renderer/src/parsers/default-schema-validator.js 98.59% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dc98c7...9c1870b. Read the comment docs.

Hyperkid123
Hyperkid123 approved these changes Apr 1, 2020
View reviewed changes
Copy link
Member

@Hyperkid123 Hyperkid123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for manual release.

@Hyperkid123 Hyperkid123 merged commit ea66244 into data-driven-forms:v1 Apr 1, 2020
Hyperkid123 added a commit that referenced this pull request Apr 1, 2020
@Hyperkid123
backport of #407, released renderer 1.31.1
9b3e8a4
@Hyperkid123
Copy link
Member

Backport released in v1.31.1 of react-form-renderer package.

@rvsia rvsia deleted the fixOr branch April 28, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hyperkid123 Hyperkid123 Hyperkid123 approved these changes

Assignees

@Hyperkid123 Hyperkid123

Labels
bug Something isn't working renderer React form renderer PR V1 backports for V1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvsia @Hyperkid123