Skip to content

Conversation

pan93412
Copy link
Member

@pan93412 pan93412 commented Oct 7, 2025

  • refactor: clean up permissions
  • refactor: refine default scope set and group
  • chore(setup): update description
  • refactor(setup): update all new-user references
  • refactor(setup): update all references to 'verification'

@pan93412 pan93412 self-assigned this Oct 7, 2025
Copy link

linear bot commented Oct 7, 2025

@pan93412 pan93412 requested a review from Copilot October 7, 2025 01:49
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the user account system by renaming "new-user" to "student" and simplifying the verification system. It removes the verification flow that allowed users to self-verify and transitions to a manual verification system by administrators.

  • Renamed all "new-user" references to "student" throughout the codebase
  • Removed the verification mutation and related GraphQL endpoints
  • Updated scope sets to remove verification permissions and add student-specific permissions

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
internal/useraccount/models.go Updated constants to rename new-user to student
internal/useraccount/register_flow.go Updated verification flow to use student group
internal/setup/setup.go Refactored setup to create student group instead of new-user group
graph/user.graphqls Removed verification mutation endpoint
graph/user.resolvers.go Removed verification resolver implementation
docs/scope.md Updated scope documentation to remove verification scope
Multiple test files Updated tests to use student group instead of new-user group

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@pan93412 pan93412 requested a review from Copilot October 7, 2025 01:51
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@pan93412 pan93412 merged commit 3d0a780 into main Oct 7, 2025
1 check passed
@pan93412 pan93412 deleted the pan93412/dbp-99-clean-up-backend-default-groups branch October 7, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant