-
Notifications
You must be signed in to change notification settings - Fork 0
DBP-99: clean up backend default groups #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBP-99: clean up backend default groups #20
Conversation
pan93412
commented
Oct 7, 2025
- refactor: clean up permissions
- refactor: refine default scope set and group
- chore(setup): update description
- refactor(setup): update all new-user references
- refactor(setup): update all references to 'verification'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the user account system by renaming "new-user" to "student" and simplifying the verification system. It removes the verification flow that allowed users to self-verify and transitions to a manual verification system by administrators.
- Renamed all "new-user" references to "student" throughout the codebase
- Removed the verification mutation and related GraphQL endpoints
- Updated scope sets to remove verification permissions and add student-specific permissions
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
internal/useraccount/models.go | Updated constants to rename new-user to student |
internal/useraccount/register_flow.go | Updated verification flow to use student group |
internal/setup/setup.go | Refactored setup to create student group instead of new-user group |
graph/user.graphqls | Removed verification mutation endpoint |
graph/user.resolvers.go | Removed verification resolver implementation |
docs/scope.md | Updated scope documentation to remove verification scope |
Multiple test files | Updated tests to use student group instead of new-user group |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.