Skip to content

DBP-99: clean up backend default groups #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 7, 2025
Merged

DBP-99: clean up backend default groups #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b637d86
refactor: clean up permissions
pan93412 Oct 7, 2025
bcbface
refactor: refine default scope set and group
pan93412 Oct 7, 2025
64ae7cf
chore(setup): update description
pan93412 Oct 7, 2025
d428a0e
refactor(setup): update all new-user references
pan93412 Oct 7, 2025
6b6662c
refactor(setup): update all references to 'verification'
pan93412 Oct 7, 2025
7542a99
fix: typo
pan93412 Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 18 additions & 17 deletions cli/promote_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"github.com/database-playground/backend-v2/ent/group"
"github.com/database-playground/backend-v2/ent/user"
"github.com/database-playground/backend-v2/internal/testhelper"
"github.com/database-playground/backend-v2/internal/useraccount"

_ "github.com/mattn/go-sqlite3"
)
Expand All @@ -24,17 +25,17 @@ func TestPromoteAdmin(t *testing.T) {
t.Fatalf("Setup failed: %v", err)
}

// Get the new-user group to assign to the user initially
newUserGroup, err := entClient.Group.Query().Where(group.Name("new-user")).Only(ctx)
// Get the student group to assign to the user initially
studentGroup, err := entClient.Group.Query().Where(group.Name(useraccount.StudentGroupSlug)).Only(ctx)
if err != nil {
t.Fatalf("Failed to get new-user group: %v", err)
t.Fatalf("Failed to get student group: %v", err)
}

// Create a test user
testUser, err := entClient.User.Create().
SetEmail("test@example.com").
SetName("Test User").
SetGroup(newUserGroup).
SetGroup(studentGroup).
Save(ctx)
if err != nil {
t.Fatalf("Failed to create test user: %v", err)
Expand Down Expand Up @@ -148,17 +149,17 @@ func TestPromoteAdmin(t *testing.T) {
t.Fatalf("Setup failed: %v", err)
}

// Get the new-user group to assign to the user initially
newUserGroup, err := entClient.Group.Query().Where(group.Name("new-user")).Only(ctx)
// Get the student group to assign to the user initially
studentGroup, err := entClient.Group.Query().Where(group.Name(useraccount.StudentGroupSlug)).Only(ctx)
if err != nil {
t.Fatalf("Failed to get new-user group: %v", err)
t.Fatalf("Failed to get student group: %v", err)
}

// Create a test user
_, err = entClient.User.Create().
SetEmail("test@example.com").
SetName("Test User").
SetGroup(newUserGroup).
SetGroup(studentGroup).
Save(ctx)
if err != nil {
t.Fatalf("Failed to create test user: %v", err)
Expand Down Expand Up @@ -188,17 +189,17 @@ func TestPromoteAdmin(t *testing.T) {
t.Fatalf("Setup failed: %v", err)
}

// Get the new-user group to assign to users initially
newUserGroup, err := entClient.Group.Query().Where(group.Name("new-user")).Only(ctx)
// Get the student group to assign to users initially
studentGroup, err := entClient.Group.Query().Where(group.Name(useraccount.StudentGroupSlug)).Only(ctx)
if err != nil {
t.Fatalf("Failed to get new-user group: %v", err)
t.Fatalf("Failed to get student group: %v", err)
}

// Create multiple test users
user1, err := entClient.User.Create().
SetEmail("user1@example.com").
SetName("User 1").
SetGroup(newUserGroup).
SetGroup(studentGroup).
Save(ctx)
if err != nil {
t.Fatalf("Failed to create user1: %v", err)
Expand All @@ -207,7 +208,7 @@ func TestPromoteAdmin(t *testing.T) {
user2, err := entClient.User.Create().
SetEmail("user2@example.com").
SetName("User 2").
SetGroup(newUserGroup).
SetGroup(studentGroup).
Save(ctx)
if err != nil {
t.Fatalf("Failed to create user2: %v", err)
Expand Down Expand Up @@ -271,17 +272,17 @@ func TestPromoteAdmin(t *testing.T) {
t.Fatalf("Setup failed: %v", err)
}

// Get the new-user group to assign to the user initially
newUserGroup, err := entClient.Group.Query().Where(group.Name("new-user")).Only(ctx)
// Get the student group to assign to the user initially
studentGroup, err := entClient.Group.Query().Where(group.Name(useraccount.StudentGroupSlug)).Only(ctx)
if err != nil {
t.Fatalf("Failed to get new-user group: %v", err)
t.Fatalf("Failed to get student group: %v", err)
}

// Create a test user with lowercase email
_, err = entClient.User.Create().
SetEmail("test@example.com").
SetName("Test User").
SetGroup(newUserGroup).
SetGroup(studentGroup).
Save(ctx)
if err != nil {
t.Fatalf("Failed to create test user: %v", err)
Expand Down
Loading