Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making "sample results" link a relative URL #22

Closed
nmagee opened this issue Feb 6, 2018 · 4 comments
Closed

Consider making "sample results" link a relative URL #22

nmagee opened this issue Feb 6, 2018 · 4 comments

Comments

@nmagee
Copy link
Member

nmagee commented Feb 6, 2018

tags$a(href = "http://lolaweb.databio.org/?key=CD59REQLJU4AFMX",

A very minor suggestion: I'm not sure if Shiny accepts relative URLs, but if this is changed to a relative path, it will keep you on the respective container (dev, staging, latest).

@nsheff
Copy link
Member

nsheff commented Feb 6, 2018

👍 yeah I thought this as well

@vpnagraj
Copy link
Collaborator

vpnagraj commented Feb 7, 2018

ok well i can definitely do that (and had considered it too) ... but that will limit the portability for folks who are trying to run the app locally ... that is unless we provide instructions for how to download that sample cache and make it available somewhere?

thoughts?

@nsheff
Copy link
Member

nsheff commented Feb 7, 2018

can it be included in the package? it should be relatively small...

@vpnagraj
Copy link
Collaborator

vpnagraj commented Feb 7, 2018

cool ... just pushed a fix for the relative url, so i'm going to close this out for now

that said, i think there is a bigger question of making all reference data (and sample caches) available in one place for people ... and documenting how to use LOLAweb locally ... will open a separate issue for that

@vpnagraj vpnagraj closed this as completed Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants