logger_kwargs isn't used in one branch of the pipeline manager setup

[vreuter]

In the pipeline manager constructor, it looks like logger_kwargs isn't used when args is non-empty or non-null. Is this intended? There's also no docstring for logger_kwargs, where it could be noted if this is indeed intended behavior, or at least describing what these values are to be used for.

pypiper/pypiper/manager.py

Lines 216 to 232 in 3a8465a

	if not args:
	# strict is only for logger_via_cli.
	kwds = {k: v for k, v in logger_kwargs.items() if k != "strict"}
	try:
	name = kwds.pop("name")
	except KeyError:
	name = default_logname
	self._logger = logmuse.init_logger(name, **kwds)
	self.debug("Logger set with logmuse.init_logger")
	else:
	logger_kwargs.setdefault("name", default_logname)
	try:
	self._logger = logmuse.logger_via_cli(args)
	self.debug("Logger set with logmuse.logger_via_cli")
	except logmuse.est.AbsentOptionException:
	self._logger = logmuse.init_logger("pypiper", level="DEBUG")
	self.debug("logger_via_cli failed; Logger set with logmuse.init_logger")

Possibly related to #210

[vreuter]

Perhaps **logger_kwargs should be passed to logmuse.init_logger?

[vreuter]

^^ controlling, perhaps, for possibility of collision w/ level (i.e., either remove level from the keyword args mapping if it's there--noting difference w/ DEBUG if that's the case--or not passing level='DEBUG' if level's already in the kwargs mapping.

[nsheff]

Hmm, I never understood what logmuse was doing with init_logger and I still don't :).

you taught me everything I know about the logging package

[vreuter]

Closed by #215