v0.6.2 #20
Merged
v0.6.2 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsheff
reviewed
Oct 9, 2019
| @@ -337,8 +337,7 @@ def select_config(config_filepath=None, | |||
| if config_filepath: | |||
| if not check_exist or os.path.isfile(config_filepath): | |||
| return config_filepath | |||
| _LOGGER.error("Config file path isn't a file: {}". | |||
| format(config_filepath)) | |||
| _LOGGER.error("Config file path isn't a file: {}".format(config_filepath)) | |||
There was a problem hiding this comment.
are you intentionally changing the formatting away from respecting the line length limit?
|
I didn't review the earlier changes that created the issue, but just looking at this it seems fine to me. |
nsheff
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19