Increase cluster refresh timeout to 10 minutes. (#130)

- The default refresh time for cluster list is 10 minutes now.
- Clicking on the refresh button or opening the quickpick will refresh
the list as well.

Author: kartikgupta-db

packages/databricks-vscode/.vscode/launch.json

@@ -9,11 +9,15 @@
             "name": "Run Extension",
             "type": "extensionHost",
             "request": "launch",
-            "args": ["--extensionDevelopmentPath=${workspaceFolder}"],
-            "outFiles": ["${workspaceFolder}/out/**/*.js"],
+            "args": [
+                "--extensionDevelopmentPath=${workspaceFolder}"
+            ],
+            "outFiles": [
+                "${workspaceFolder}/out/**/*.js"
+            ],
             "preLaunchTask": "${defaultBuildTask}",
             "env": {
-                "DATABRICKS_DEBUG_HEADERS": "true"
+                "DATABRICKS_DEBUG_HEADERS": "false"
             }
         },
         {
@@ -24,10 +28,12 @@
                 "--extensionDevelopmentPath=${workspaceFolder}",
                 "--extensionTestsPath=${workspaceFolder}/out/test/suite"
             ],
-            "outFiles": ["${workspaceFolder}/out/**/*.js"],
+            "outFiles": [
+                "${workspaceFolder}/out/**/*.js"
+            ],
             "preLaunchTask": "${defaultBuildTask}",
             "env": {
-                "DATABRICKS_DEBUG_HEADERS": "true"
+                "DATABRICKS_DEBUG_HEADERS": "false"
             }
         }
     ]

packages/databricks-vscode/src/cluster/ClusterLoader.ts

@@ -44,14 +44,17 @@ export class ClusterLoader implements Disposable {
     private _onDidStop: EventEmitter<void> = new EventEmitter<void>();
     private readonly onDidStop: Event<void> = this._onDidStop.event;
 
+    private _onStopRequested: EventEmitter<void> = new EventEmitter<void>();
+    private readonly onStopRequested: Event<void> = this._onStopRequested.event;
+
     private _onDidChange: EventEmitter<void> = new EventEmitter<void>();
     readonly onDidChange: Event<void> = this._onDidChange.event;
 
     private disposables: Disposable[] = [];
 
     constructor(
         private connectionManager: ConnectionManager,
-        refreshTime: Time = new Time(5, TimeUnits.seconds)
+        refreshTime: Time = new Time(10, TimeUnits.minutes)
     ) {
         this.refreshTime = refreshTime;
         this.disposables.push(this.onDidStop(() => (this.stopped = true)));
@@ -102,9 +105,13 @@ export class ClusterLoader implements Disposable {
             return;
         }
         let allClusters = sortClusters(
-            (await Cluster.list(apiClient)).filter((c) =>
-                ["UI", "API"].includes(c.source)
-            )
+            (await Cluster.list(apiClient))
+                .filter((c) => ["UI", "API"].includes(c.source))
+                .filter(
+                    (c) =>
+                        c.details.data_security_mode !== "SINGLE_USER" ||
+                        this.isValidSingleUser(c)
+                )
         );
 
         const permissionApi = new PermissionsService(apiClient);
@@ -123,15 +130,16 @@ export class ClusterLoader implements Disposable {
             }
 
             const task = new Promise<void>((resolve) => {
+                const hasUcPerm =
+                    c.details.data_security_mode !== "SINGLE_USER" ||
+                    this.isValidSingleUser(c);
+
                 this.hasPerm(c, permissionApi)
                     .then((hasPerm) => {
                         if (!this.running) {
                             return resolve();
                         }
-                        const keepCluster =
-                            (c.details.data_security_mode !== "SINGLE_USER" ||
-                                this.isValidSingleUser(c)) &&
-                            hasPerm;
+                        const keepCluster = hasUcPerm && hasPerm;
 
                         if (this._clusters.has(c.id) && !keepCluster) {
                             this._clusters.delete(c.id);
@@ -192,6 +200,7 @@ export class ClusterLoader implements Disposable {
                 break;
             }
             await new Promise((resolve) => {
+                this.disposables.push(this.onStopRequested(resolve));
                 setTimeout(resolve, this.refreshTime.toMillSeconds().value);
             });
         }
@@ -205,6 +214,7 @@ export class ClusterLoader implements Disposable {
         }
 
         this.running = false;
+        this._onStopRequested.fire();
         await new Promise((resolve) => {
             this.disposables.push(this.onDidStop(resolve));
         });

packages/databricks-vscode/src/configuration/ConnectionCommands.ts

@@ -110,6 +110,7 @@ export class ConnectionCommands implements Disposable {
             quickPick.keepScrollPosition = true;
             quickPick.busy = true;
 
+            this.clusterModel.refresh();
             const refreshQuickPickItems = () => {
                 let clusters = this.clusterModel.roots ?? [];
                 quickPick.items = clusters.map((c) => {

packages/databricks-vscode/src/configuration/selectProfileWizard.ts

@@ -56,7 +56,7 @@ export async function selectProfile(
                 const option = await window.showErrorMessage(
                     `Can't parse config file`,
                     {
-                        detail: e.message,
+                        detail: (e as ConfigFileError).message,
                     },
                     "Open Config File",
                     "Backup and Overwrite Config File"