Fix az login on Windows under cmd.exe (#1513)

## Changes
If the default windows shell is cmd.exe, the az login fails due to our
handling of the command arguments.

We've added the arg handling to fix issues when the vscode is installed
in the folder that contains spaces, and so our databricks cli calls were
failing. AZ cli doesn't have the same problems, as it's installed
separately from the extension, so here I'm reverting back to using
execFile without custom argument handling.

Fixes #1468


<!-- Summary of your changes that are easy to understand -->

## Tests

On win vm

Author: ilia-db

packages/databricks-vscode/scripts/fetch-databricks-cli.sh

@@ -15,7 +15,7 @@ fi
 
 CLI_DIR=$(mktemp -d -t databricks-XXXXXXXXXX)
 pushd $CLI_DIR
-gh release download v${CLI_VERSION} --pattern "databricks_cli_${CLI_VERSION}_${CLI_ARCH}.zip" --repo databricks/cli
+curl -L -O "https://github.com/databricks/cli/releases/download/v${CLI_VERSION}/databricks_cli_${CLI_VERSION}_${CLI_ARCH}.zip"
 unzip databricks_*_$CLI_ARCH.zip
 rm databricks_*_$CLI_ARCH.zip
 ls

packages/databricks-vscode/src/cli/CliWrapper.ts

@@ -33,10 +33,11 @@ function getEscapedCommandAndAgrs(
     options: SpawnOptionsWithoutStdio
 ) {
     if (process.platform === "win32") {
+        const cmdArgs = args.slice();
         args = [
-            "/d", //Disables execution of AutoRun commands, which are like .bashrc commands.
-            "/c", //Carries out the command specified by <string> and then exits the command processor.
-            `""${cmd}" ${args.map((a) => `"${a}"`).join(" ")}"`,
+            "/d", // Disables execution of AutoRun commands, which are like .bashrc commands.
+            "/c", // Carries out the command specified by <string> and then exits the command processor.
+            `""${cmd}" ${cmdArgs.map((a) => `"${a}"`).join(" ")}"`,
         ];
         cmd = "cmd.exe";
         options = {...options, windowsVerbatimArguments: true};

packages/databricks-vscode/src/configuration/auth/AzureCliCheck.ts

@@ -9,7 +9,7 @@ import {Loggers} from "../../logger";
 import {AzureCliAuthProvider} from "./AuthProvider";
 import {orchestrate, OrchestrationLoopError, Step} from "./orchestrate";
 import {ShellUtils} from "../../utils";
-import {execFile} from "../../cli/CliWrapper";
+import {cancellableExecFile} from "../../cli/CliWrapper";
 import {
     FileNotFoundException,
     isFileNotFound,
@@ -40,7 +40,12 @@ async function execFileWithShell(
     stderr: string;
 }> {
     try {
-        return await execFile(cmd, args, {shell: true}, cancellationToken);
+        return await cancellableExecFile(
+            cmd,
+            args,
+            {shell: true},
+            cancellationToken
+        );
     } catch (e) {
         if (isFileNotFound(e)) {
             throw new FileNotFoundException(e.message);