Use sync icon for sync destination and make it green (#1054)

## Changes
<!-- Summary of your changes that are easy to understand -->

## Tests
<!-- How is this tested? -->

Author: kartikgupta-db

packages/databricks-vscode/src/bundle/BundleInitWizard.ts

@@ -214,7 +214,7 @@ export class BundleInitWizard {
             return Uri.file(choice.label);
         }
         const choices = await window.showOpenDialog({
-            title: "Chose a folder where you would want your new project to be",
+            title: "Choose a folder where you would want your new project to be",
             openLabel: "Select folder",
             defaultUri: workspaceUri,
             canSelectFolders: true,

packages/databricks-vscode/src/configuration/ui/ConfigurationDataProvider.ts

@@ -14,7 +14,6 @@ import {BundleTargetComponent} from "./BundleTargetComponent";
 import {AuthTypeComponent} from "./AuthTypeComponent";
 import {ClusterComponent} from "./ClusterComponent";
 import {SyncDestinationComponent} from "./SyncDestinationComponent";
-import {CodeSynchronizer} from "../../sync";
 import {BundleProjectManager} from "../../bundle/BundleProjectManager";
 
 /**
@@ -35,16 +34,11 @@ export class ConfigurationDataProvider
         new BundleTargetComponent(this.configModel),
         new AuthTypeComponent(this.connectionManager, this.configModel),
         new ClusterComponent(this.connectionManager, this.configModel),
-        new SyncDestinationComponent(
-            this.codeSynchronizer,
-            this.connectionManager,
-            this.configModel
-        ),
+        new SyncDestinationComponent(this.connectionManager, this.configModel),
     ];
     constructor(
         private readonly connectionManager: ConnectionManager,
         private readonly bundleProjectManager: BundleProjectManager,
-        private readonly codeSynchronizer: CodeSynchronizer,
         private readonly configModel: ConfigModel
     ) {
         this.disposables.push(

packages/databricks-vscode/src/configuration/ui/SyncDestinationComponent.ts

@@ -1,5 +1,4 @@
 import {posix} from "path/posix";
-import {CodeSynchronizer} from "../../sync";
 import {ConfigModel} from "../models/ConfigModel";
 import {ConnectionManager} from "../ConnectionManager";
 import {BaseComponent} from "./BaseComponent";
@@ -8,56 +7,13 @@ import {TreeItemCollapsibleState, ThemeIcon, ThemeColor} from "vscode";
 import {DecorationUtils} from "../../ui/bundle-resource-explorer/utils";
 
 const TREE_ICON_ID = "WORKSPACE";
-function getContextValue(key: string) {
-    return `databricks.configuration.sync.${key}`;
-}
-
-function getTreeItemsForSyncState(codeSynchroniser: CodeSynchronizer) {
-    let icon, contextValue;
-    switch (codeSynchroniser.state) {
-        case "IN_PROGRESS":
-            icon = new ThemeIcon(
-                "sync~spin",
-                new ThemeColor("debugIcon.startForeground")
-            );
-            contextValue = getContextValue("running");
-            break;
-
-        case "STOPPED":
-            icon = new ThemeIcon(
-                "stop-circle",
-                new ThemeColor("notificationsErrorIcon.foreground")
-            );
-            contextValue = getContextValue("stopped");
-            break;
-
-        case "WATCHING_FOR_CHANGES":
-            icon = new ThemeIcon(
-                "eye",
-                new ThemeColor("debugIcon.startForeground")
-            );
-            contextValue = getContextValue("watching");
-            break;
-
-        default:
-            icon = new ThemeIcon(
-                "testing-error-icon",
-                new ThemeColor("notificationsErrorIcon.foreground")
-            );
-            contextValue = getContextValue("error");
-            break;
-    }
-
-    return {icon, contextValue};
-}
 
 /**
  * Component for displaying sync destination details. Sync destination is
  * always pulled from the bundle.
  */
 export class SyncDestinationComponent extends BaseComponent {
     constructor(
-        private readonly codeSynchronizer: CodeSynchronizer,
         private readonly connectionManager: ConnectionManager,
         private readonly configModel: ConfigModel
     ) {
@@ -93,10 +49,7 @@ export class SyncDestinationComponent extends BaseComponent {
             return [];
         }
 
-        const {icon, contextValue} = getTreeItemsForSyncState(
-            this.codeSynchronizer
-        );
-
+        const contextValue = "databricks.configuration.sync";
         const url = await this.getUrl();
 
         return [
@@ -106,7 +59,7 @@ export class SyncDestinationComponent extends BaseComponent {
                 description: posix.basename(posix.dirname(config)),
                 collapsibleState: TreeItemCollapsibleState.Expanded,
                 contextValue: url ? `${contextValue}.has-url` : contextValue,
-                iconPath: icon,
+                iconPath: new ThemeIcon("sync", new ThemeColor("charts.green")),
                 resourceUri: url
                     ? undefined
                     : DecorationUtils.getModifiedStatusDecoration(

packages/databricks-vscode/src/extension.ts

@@ -430,7 +430,6 @@ export async function activate(
     const configurationDataProvider = new ConfigurationDataProvider(
         connectionManager,
         bundleProjectManager,
-        synchronizer,
         configModel
     );