Don't allow per file run modes in prod/staging target (#1032)

## Changes
* We still keep showing the actual options to run, because this gives
users a pathway to figure out why the modes are disabled.
* We want to block this because we write wrappers into the remote sync
desitnation, which is essentially editing the prod deployment. We don't
want to do that.

## Tests
<!-- How is this tested? -->

Author: kartikgupta-db

packages/databricks-vscode/src/extension.ts

@@ -584,12 +584,14 @@ export async function activate(
     const runCommands = new RunCommands(connectionManager);
     const debugFactory = new DatabricksDebugAdapterFactory(
         connectionManager,
+        configModel,
         bundleCommands,
         context,
         wsfsAccessVerifier
     );
     const debugWorkflowFactory = new DatabricksWorkflowDebugAdapterFactory(
         connectionManager,
+        configModel,
         wsfsAccessVerifier,
         context,
         bundleCommands

packages/databricks-vscode/src/run/DatabricksDebugAdapter.ts

@@ -24,6 +24,7 @@ import {WorkspaceFsAccessVerifier} from "../workspace-fs";
 import {DatabricksRuntime} from "./DatabricksRuntime";
 import {Subject} from "./Subject";
 import {BundleCommands} from "../ui/bundle-resource-explorer/BundleCommands";
+import {ConfigModel} from "../configuration/models/ConfigModel";
 
 /**
  * This interface describes the mock-debug specific launch attributes
@@ -47,6 +48,7 @@ export class DatabricksDebugAdapterFactory
 {
     constructor(
         private connection: ConnectionManager,
+        private configModel: ConfigModel,
         private bundleCommands: BundleCommands,
         private context: ExtensionContext,
         private wsfsAccessVerifier: WorkspaceFsAccessVerifier
@@ -58,6 +60,7 @@ export class DatabricksDebugAdapterFactory
         return new DebugAdapterInlineImplementation(
             new DatabricksDebugSession(
                 this.connection,
+                this.configModel,
                 this.bundleCommands,
                 this.context,
                 this.wsfsAccessVerifier
@@ -73,6 +76,7 @@ export class DatabricksDebugSession extends LoggingDebugSession {
 
     constructor(
         connection: ConnectionManager,
+        configModel: ConfigModel,
         bundleCommands: BundleCommands,
         context: ExtensionContext,
         wsfsAccessVerifier: WorkspaceFsAccessVerifier
@@ -81,6 +85,7 @@ export class DatabricksDebugSession extends LoggingDebugSession {
 
         this.runtime = new DatabricksRuntime(
             connection,
+            configModel,
             bundleCommands,
             context,
             wsfsAccessVerifier

packages/databricks-vscode/src/run/DatabricksRuntime.ts

@@ -20,13 +20,18 @@ import {
     SyncDestinationMapper,
 } from "../sync/SyncDestination";
 import {ConnectionManager} from "../configuration/ConnectionManager";
-import {promptForClusterAttach, promptForClusterStart} from "./prompts";
+import {
+    promptForChangingTargetMode,
+    promptForClusterAttach,
+    promptForClusterStart,
+} from "./prompts";
 import * as fs from "node:fs/promises";
 import {parseErrorResult} from "./ErrorParser";
 import path from "node:path";
 import {WorkspaceFsAccessVerifier} from "../workspace-fs";
 import {Time, TimeUnits} from "@databricks/databricks-sdk";
 import {BundleCommands} from "../ui/bundle-resource-explorer/BundleCommands";
+import {ConfigModel} from "../configuration/models/ConfigModel";
 
 export interface OutputEvent {
     type: "prio" | "out" | "err";
@@ -93,6 +98,7 @@ export class DatabricksRuntime implements Disposable {
 
     constructor(
         private connection: ConnectionManager,
+        private readonly configModel: ConfigModel,
         private bundleCommands: BundleCommands,
         private context: ExtensionContext,
         private wsfsAccessVerifier: WorkspaceFsAccessVerifier
@@ -123,6 +129,11 @@ export class DatabricksRuntime implements Disposable {
                 log("Connecting to databricks...");
                 await this.cancellable(this.connection.waitForConnect());
             }
+            const mode = await this.configModel.get("mode");
+            if (mode !== "development") {
+                promptForChangingTargetMode(mode);
+                return this._onErrorEmitter.fire(undefined);
+            }
             const syncDestinationMapper = this.connection.syncDestinationMapper;
             if (syncDestinationMapper === undefined) {
                 throw new Error("No sync destination found");

packages/databricks-vscode/src/run/DatabricksWorkflowDebugAdapter.ts

@@ -22,11 +22,16 @@ import {DebugProtocol} from "@vscode/debugprotocol";
 import {ConnectionManager} from "../configuration/ConnectionManager";
 import {Subject} from "./Subject";
 import {WorkflowRunner} from "./WorkflowRunner";
-import {promptForClusterAttach, promptForClusterStart} from "./prompts";
+import {
+    promptForChangingTargetMode,
+    promptForClusterAttach,
+    promptForClusterStart,
+} from "./prompts";
 import {LocalUri} from "../sync/SyncDestination";
 import {WorkspaceFsAccessVerifier} from "../workspace-fs";
 import {FileUtils} from "../utils";
 import {BundleCommands} from "../ui/bundle-resource-explorer/BundleCommands";
+import {ConfigModel} from "../configuration/models/ConfigModel";
 
 /**
  * This interface describes the mock-debug specific launch attributes
@@ -52,6 +57,7 @@ export class DatabricksWorkflowDebugAdapterFactory
 
     constructor(
         private connection: ConnectionManager,
+        private configModel: ConfigModel,
         private wsfsAccessVerifier: WorkspaceFsAccessVerifier,
         context: ExtensionContext,
         bundleCommands: BundleCommands
@@ -71,6 +77,7 @@ export class DatabricksWorkflowDebugAdapterFactory
         return new DebugAdapterInlineImplementation(
             new DatabricksWorkflowDebugSession(
                 this.connection,
+                this.configModel,
                 this.workflowRunner,
                 this.wsfsAccessVerifier
             )
@@ -85,6 +92,7 @@ export class DatabricksWorkflowDebugSession extends LoggingDebugSession {
 
     constructor(
         private connection: ConnectionManager,
+        private configModel: ConfigModel,
         private workflowRunner: WorkflowRunner,
         private wsfsAccessVerifier: WorkspaceFsAccessVerifier
     ) {
@@ -174,6 +182,12 @@ export class DatabricksWorkflowDebugSession extends LoggingDebugSession {
             await this.connection.waitForConnect();
         }
 
+        const mode = await this.configModel.get("mode");
+        if (mode !== "development") {
+            promptForChangingTargetMode(mode);
+            return this.onError();
+        }
+
         const cluster = this.connection.cluster;
         const workspaceClient = this.connection.workspaceClient;
 
@@ -184,7 +198,7 @@ export class DatabricksWorkflowDebugSession extends LoggingDebugSession {
         const syncDestinationMapper = this.connection.syncDestinationMapper;
         if (!syncDestinationMapper) {
             return this.onError(
-                "You must configure code synchronization to run on Databricks"
+                "No sync destination found. Maybe the databricks.yml is misconfgured."
             );
         }
 

packages/databricks-vscode/src/run/RunCommands.ts

@@ -1,6 +1,5 @@
 import {debug, Uri, window} from "vscode";
 import {ConnectionManager} from "../configuration/ConnectionManager";
-import {promptForAttachingSyncDest} from "./prompts";
 import {FileUtils} from "../utils";
 import {LocalUri} from "../sync/SyncDestination";
 
@@ -54,8 +53,9 @@ export class RunCommands {
                 }
 
                 if (this.connection.syncDestinationMapper === undefined) {
-                    promptForAttachingSyncDest();
-                    return;
+                    throw new Error(
+                        "No sync destination found. Maybe the databricks.yml is misconfgured."
+                    );
                 }
 
                 await debug.startDebugging(

packages/databricks-vscode/src/run/prompts.ts

@@ -26,16 +26,16 @@ export async function promptForClusterStart() {
     }
 }
 
-export async function promptForAttachingSyncDest() {
+export async function promptForChangingTargetMode(curMode: string | undefined) {
     const response = await window.showErrorMessage(
-        "Please configure a Sync Destination",
-        "Configure Sync Destination",
+        `Running is disabled for non development targets. Current target mode is ${curMode}.`,
+        "Change Target Mode",
         "Cancel"
     );
     switch (response) {
-        case "Configure Sync Destination":
+        case "Change Target Mode":
             await commands.executeCommand(
-                "databricks.connection.attachSyncDestination"
+                "databricks.connection.bundle.selectTarget"
             );
     }
 }