Fix bundle-init on windows (#1058)

Supply full environment to the terminal (but still use `strictEnv` to
ignore environmentCollection)

Also use cross-platform read function.

Author: ilia-db

packages/databricks-vscode/src/bundle/BundleInitWizard.ts

@@ -13,6 +13,7 @@ import {LoginWizard} from "../configuration/LoginWizard";
 import {CliWrapper} from "../cli/CliWrapper";
 import {getSubProjects} from "./BundleFileSet";
 import {tmpdir} from "os";
+import {ShellUtils} from "../utils";
 
 export async function promptToOpenSubProjects(
     projects: {absolute: Uri; relative: Uri}[]
@@ -141,7 +142,12 @@ export class BundleInitWizard {
             name: "Databricks Project Init",
             isTransient: true,
             location: TerminalLocation.Editor,
-            env: this.cli.getBundleInitEnvVars(authProvider),
+            env: {
+                // Without supplying full environment and with `strictEnv: true` PowerShell will fail to start.
+                // On unix-like systems we don't require full environment, but it doesn't hurt.
+                ...process.env,
+                ...this.cli.getBundleInitEnvVars(authProvider),
+            },
             // Without strict env we will inherit our environmentVariableCollection
             // which will override auth env vars we provide in this call.
             strictEnv: true,
@@ -156,7 +162,7 @@ export class BundleInitWizard {
             this.cli.escapePathArgument(parentFolder.fsPath),
         ].join(" ");
         const initialPrompt = `clear; echo "Executing: databricks ${args}\nFollow the steps below to create your new Databricks project.\n"`;
-        const finalPrompt = `echo "Press any key to close the terminal and continue ..."; read; exit`;
+        const finalPrompt = `echo "\nPress any key to close the terminal and continue ..."; ${ShellUtils.readCmd()}; exit`;
         terminal.sendText(
             `${initialPrompt}; ${this.cli.cliPath} ${args}; ${finalPrompt}`
         );

packages/databricks-vscode/src/configuration/auth/AzureCliCheck.ts

@@ -8,6 +8,7 @@ import {commands, Disposable, Uri, window} from "vscode";
 import {Loggers} from "../../logger";
 import {AzureCliAuthProvider} from "./AuthProvider";
 import {orchestrate, OrchestrationLoopError, Step} from "./orchestrate";
+import {ShellUtils} from "../../utils";
 
 // eslint-disable-next-line @typescript-eslint/naming-convention
 const {NamedLogger} = logging;
@@ -317,7 +318,7 @@ export class AzureCliCheck implements Disposable {
                     this.azBinPath
                 } login --allow-no-subscriptions ${useDeviceCode} ${
                     tenant ? "-t " + tenant : ""
-                }; echo "Press any key to close the terminal and continue ..."; read; exit`
+                }; echo "Press any key to close the terminal and continue ..."; ${ShellUtils.readCmd()}; exit`
             );
 
             return await Promise.race<boolean>([

packages/databricks-vscode/src/utils/index.ts

@@ -1,5 +1,6 @@
 export * as FileUtils from "./fileUtils";
 export * as UrlUtils from "./urlUtils";
+export * as ShellUtils from "./shellUtils";
 export * as UtilsCommands from "./UtilsCommands";
 export * as PackageJsonUtils from "./packageJsonUtils";
 export * as EnvVarGenerators from "./envVarGenerators";

packages/databricks-vscode/src/utils/shellUtils.ts

@@ -0,0 +1,8 @@
+import {env} from "vscode";
+
+export function readCmd() {
+    if (env.shell.toLowerCase().includes("powershell")) {
+        return "Read-Host";
+    }
+    return "read";
+}