Cancel run in the UI when CLI fails (#1102)

## Changes
When CLI fails before we have a run ID, the UI still remains in the
running state until timeout. We need to move the UI to the
errored/cancelled state when terminal is killed or the CLI errors.

## Tests
<!-- How is this tested? -->

Author: kartikgupta-db

packages/databricks-vscode/src/bundle/run/BundleRunStatusManager.ts

@@ -93,9 +93,20 @@ export class BundleRunStatusManager implements Disposable {
             })
         );
         this.onDidChangeEmitter.fire();
-        await this.bundleRunTerminalManager.run(resourceKey, (data) => {
-            remoteRunStatus.parseId(data);
-        });
+        await this.bundleRunTerminalManager.run(
+            resourceKey,
+            (data) => {
+                remoteRunStatus.parseId(data);
+            },
+            async (exitCode) => {
+                await remoteRunStatus.cancel();
+                if (exitCode !== 0) {
+                    remoteRunStatus.runState = "error";
+                } else {
+                    remoteRunStatus.runState = "cancelled";
+                }
+            }
+        );
     }
 
     async cancel(resourceKey: string) {

packages/databricks-vscode/src/bundle/run/BundleRunTerminalManager.ts

@@ -23,7 +23,11 @@ export class BundleRunTerminalManager implements Disposable {
         return `Run ${resourceKey} (${target})`;
     }
 
-    async run(resourceKey: string, onDidUpdate?: (data: string) => void) {
+    async run(
+        resourceKey: string,
+        onDidUpdate?: (data: string) => void,
+        onDidClose?: (code: number | null) => void
+    ) {
         const target = this.bundleRemoteStateModel.target;
         if (target === undefined) {
             throw new Error(`Cannot run ${resourceKey}, Target is undefined`);
@@ -88,6 +92,7 @@ export class BundleRunTerminalManager implements Disposable {
                     return;
                 }
                 terminal.pty.onDidCloseProcess((exitCode) => {
+                    onDidClose?.(exitCode);
                     if (exitCode === 0 || terminal.pty.isClosed) {
                         // Resolve when the process exits with code 0 or is closed by human action
                         resolve();

packages/databricks-vscode/src/ui/bundle-resource-explorer/BundleCommands.ts

@@ -53,13 +53,13 @@ export class BundleCommands implements Disposable {
             if (!(e instanceof Error)) {
                 throw e;
             }
-            const choice = await window.showErrorMessage(
-                "Error refreshing bundle state.",
-                "Show Logs"
-            );
-            if (choice === "Show Logs") {
-                commands.executeCommand("databricks.bundle.showLogs");
-            }
+            window
+                .showErrorMessage("Error refreshing bundle state.", "Show Logs")
+                .then((choice) => {
+                    if (choice === "Show Logs") {
+                        commands.executeCommand("databricks.bundle.showLogs");
+                    }
+                });
             throw e;
         }
     }
@@ -87,13 +87,13 @@ export class BundleCommands implements Disposable {
             if (!(e instanceof Error)) {
                 throw e;
             }
-            const choice = await window.showErrorMessage(
-                "Error deploying resource.",
-                "Show Logs"
-            );
-            if (choice === "Show Logs") {
-                commands.executeCommand("databricks.bundle.showLogs");
-            }
+            window
+                .showErrorMessage("Error deploying resource.", "Show Logs")
+                .then((choice) => {
+                    if (choice === "Show Logs") {
+                        commands.executeCommand("databricks.bundle.showLogs");
+                    }
+                });
             throw e;
         } finally {
             this.whenContext.setDeploymentState("idle");