Commit 772d112
committed
Improve login flow, properly init cluster manager
ConnectionManager first tries to login, and only after that starts listening to
configModel changes.
During login flow it updates configModel with authProvider, triggering reloading
of the config state. That's when we load clusterId from the bundle-validate model.
But the clusterId changes never trigger updateClusterManager, since they
happen before ConnectionManager is done with the login and before it started
listening to the changes.
Moving the manual update* calls after we set the auth provider (and awating till
the config model loads all the sub-configs data) fixes the problem.1 parent a55eb15 commit 772d112
File tree
1 file changed
+2
-3
lines changed- packages/databricks-vscode/src/configuration
1 file changed
+2
-3
lines changedLines changed: 2 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
246 | 246 | | |
247 | 247 | | |
248 | 248 | | |
249 | | - | |
250 | | - | |
251 | | - | |
252 | 249 | | |
253 | 250 | | |
254 | 251 | | |
255 | 252 | | |
256 | 253 | | |
| 254 | + | |
| 255 | + | |
257 | 256 | | |
258 | 257 | | |
259 | 258 | | |
| |||
0 commit comments