Update Databricks CLI to v0.218.1 (#1197)

Update Databricks CLI to v0.218.1

---------

Co-authored-by: eng-dev-ecosystem-bot <eng-dev-ecosystem-bot@users.noreply.github.com>
Co-authored-by: kartikgupta-db <kartik.gupta@databricks.com>
Co-authored-by: Kartik Gupta <88345179+kartikgupta-db@users.noreply.github.com>

Author: eng-dev-ecosystem-bot

packages/databricks-vscode/package.json

@@ -650,7 +650,7 @@
         "useYarn": false
     },
     "cli": {
-        "version": "0.216.0"
+        "version": "0.218.1"
     },
     "scripts": {
         "vscode:prepublish": "rm -rf out && yarn run package:compile && yarn run package:wrappers:write && yarn run package:jupyter-init-script:write && yarn run package:copy-webview-toolkit && yarn run generate-telemetry",

packages/databricks-vscode/src/cli/CliWrapper.test.ts

@@ -17,6 +17,7 @@ import os from "node:os";
 import crypto from "node:crypto";
 import {Context} from "@databricks/databricks-sdk/dist/context";
 import {logging} from "@databricks/databricks-sdk";
+import {writeFileSync} from "fs";
 
 const execFile = promisify(execFileCb);
 const cliPath = path.join(__dirname, "../../bin/databricks");
@@ -118,21 +119,22 @@ describe(__filename, () => {
         assert.equal(profiles.length, 0);
     });
 
-    it("should list profiles", async function () {
+    it("should list profiles", async () => {
         const logFilePath = getTempLogFilePath();
         const cli = createCliWrapper(logFilePath);
 
         await withFile(async ({path}) => {
-            await writeFile(
+            writeFileSync(
                 path,
                 `
-        host = https://cloud.databricks.com/
-        token = dapitest1234
+host = https://cloud.databricks.com/
+token = dapitest1234
 
-        [STAGING]
-        host = https://staging.cloud.databricks.com/
-        token = dapitest54321
-        `
+[STAGING]
+host = https://staging.cloud.databricks.com/
+token = dapitest54321
+`,
+                "utf-8"
             );
 
             const profiles = await cli.listProfiles(path);
@@ -149,12 +151,12 @@ describe(__filename, () => {
         });
     });
 
-    it("should load all valid profiles and return errors for rest", async () => {
+    it("should load all valid profiles", async () => {
         const logFilePath = getTempLogFilePath();
         const cli = createCliWrapper(logFilePath);
 
         await withFile(async ({path}) => {
-            await writeFile(
+            writeFileSync(
                 path,
                 `[correct]
 host = https://cloud.databricks.com/
@@ -168,41 +170,18 @@ host = https://cloud.databricks.com/
 
 [missing-host-token]
 nothing = true
-
-[typo-host]
-host = example.com
-`
+`,
+                "utf-8"
             );
 
-            const logs: {level: string; msg?: string; meta: any}[] = [];
-            const profiles = await cli.listProfiles(
-                path,
-                new Context({
-                    logger: logging.NamedLogger.getOrCreate(
-                        "cli-profile-format-test",
-                        {
-                            factory: () => {
-                                return {
-                                    log: (level, msg, meta) => {
-                                        logs.push({level, msg, meta});
-                                    },
-                                };
-                            },
-                        }
-                    ),
-                })
-            );
+            const profiles = await cli.listProfiles(path);
             assert.equal(profiles.length, 2);
 
             assert.equal(profiles[0].name, "correct");
             assert.equal(profiles[0].host, "https://cloud.databricks.com/");
 
             assert.equal(profiles[1].name, "no-token");
             assert.equal(profiles[1].host, "https://cloud.databricks.com/");
-
-            const typoLog = logs.find((log) => log.msg?.includes("typo-host"));
-            assert.ok(typoLog !== undefined);
-            assert.ok(typoLog.level === "error");
         });
     });
 

packages/databricks-vscode/src/cli/CliWrapper.ts

@@ -138,7 +138,6 @@ export class CliWrapper {
         profiles = profiles.filter((p: any) => !p.account_id);
 
         const result = [];
-
         for (const profile of profiles) {
             try {
                 result.push({