Use a tree representation to structure resource explorer UI components (#1029)

## Changes
* Use a recursive tree representation for bundle resource expliorer UI
components. This allows us to better structure UI components than the
renderer based approach.
* Add deeplinks for all bundle resources and run statuses. 

## Tests
<!-- How is this tested? -->

Author: kartikgupta-db

packages/databricks-vscode/package.json

@@ -392,6 +392,11 @@
                     "when": "view == configurationView && viewItem =~ /^databricks.configuration.(cluster|sync).*$/",
                     "group": "inline@1"
                 },
+                {
+                    "command": "databricks.utils.openExternal",
+                    "when": "viewItem =~ /^databricks.*\\.(has-url).*$/",
+                    "group": "inline@1"
+                },
                 {
                     "command": "databricks.connection.attachCluster",
                     "when": "view == clusterView",
@@ -429,7 +434,7 @@
                 },
                 {
                     "command": "databricks.bundle.cancelRun",
-                    "when": "view == dabsResourceExplorerView && viewItem =~ /^databricks.bundle.*.running.*$/",
+                    "when": "view == dabsResourceExplorerView && viewItem =~ /^databricks.bundle.*.cancellable.*$/",
                     "group": "inline@0"
                 }
             ],

packages/databricks-vscode/src/bundle/models/BundleRemoteStateModel.ts

@@ -3,32 +3,31 @@ import {CliWrapper} from "../../cli/CliWrapper";
 import {BaseModelWithStateCache} from "../../configuration/models/BaseModelWithStateCache";
 import {Mutex} from "../../locking";
 
-import {BundleTarget} from "../types";
+import {BundleTarget, Resource, ResourceKey, Resources} from "../types";
 import {AuthProvider} from "../../configuration/auth/AuthProvider";
 import lodash from "lodash";
 import {WorkspaceConfigs} from "../../vscode-objs/WorkspaceConfigs";
-import {withLogContext} from "@databricks/databricks-sdk/dist/logging";
+import {logging} from "@databricks/databricks-sdk";
 import {Loggers} from "../../logger";
 import {Context, context} from "@databricks/databricks-sdk";
+import {BundleValidateModel} from "./BundleValidateModel";
 
 /* eslint-disable @typescript-eslint/naming-convention */
-type Resources = Required<BundleTarget>["resources"];
-export type Resource<K extends keyof Required<Resources>> =
-    Required<Resources>[K];
-
+export type BundleResourceModifiedStatus = "created" | "deleted" | "updated";
 export type BundleRemoteState = BundleTarget & {
-    resources?: Resources & {
-        [r in keyof Resources]?: {
-            [k in keyof Resource<r>]?: Resource<r>[k] & {
+    resources?: Resources<BundleTarget> & {
+        [r in ResourceKey<BundleTarget>]?: {
+            [k in keyof Required<Resources<BundleTarget>>[r]]?: Resource<
+                BundleTarget,
+                r
+            > & {
                 id?: string;
-                modified_status?: "CREATED" | "DELETED" | "UPDATED";
+                modified_status?: BundleResourceModifiedStatus;
             };
         };
     };
 };
 
-export type ResourceType = keyof Resources;
-
 /* eslint-enable @typescript-eslint/naming-convention */
 
 export class BundleRemoteStateModel extends BaseModelWithStateCache<BundleRemoteState> {
@@ -40,9 +39,13 @@ export class BundleRemoteStateModel extends BaseModelWithStateCache<BundleRemote
     constructor(
         private readonly cli: CliWrapper,
         private readonly workspaceFolder: Uri,
-        private readonly workspaceConfigs: WorkspaceConfigs
+        private readonly workspaceConfigs: WorkspaceConfigs,
+        private readonly bundleValidateModel: BundleValidateModel
     ) {
         super();
+        this.bundleValidateModel.onDidChange(async () => {
+            this.refresh();
+        });
     }
 
     public async refresh() {
@@ -88,7 +91,7 @@ export class BundleRemoteStateModel extends BaseModelWithStateCache<BundleRemote
         );
     }
 
-    @withLogContext(Loggers.Extension)
+    @logging.withLogContext(Loggers.Extension)
     public init(@context ctx?: Context) {
         this.refreshInterval = setInterval(async () => {
             try {

packages/databricks-vscode/src/bundle/run/BundleRunStatus.ts

@@ -1,9 +1,10 @@
 import {EventEmitter} from "vscode";
-import {ResourceType} from "../models/BundleRemoteStateModel";
 import {RunState} from "./types";
+import {ResourceKey} from "../types";
+import {BundleRemoteState} from "../models/BundleRemoteStateModel";
 
 export abstract class BundleRunStatus {
-    abstract readonly type: ResourceType;
+    abstract readonly type: ResourceKey<BundleRemoteState>;
     protected readonly onDidChangeEmitter = new EventEmitter<void>();
     readonly onDidChange = this.onDidChangeEmitter.event;
     runId: string | undefined;

packages/databricks-vscode/src/bundle/run/BundleRunStatusManager.ts

@@ -1,14 +1,14 @@
 import {Disposable, EventEmitter} from "vscode";
 import {
+    BundleRemoteState,
     BundleRemoteStateModel,
-    Resource,
-    ResourceType,
 } from "../models/BundleRemoteStateModel";
 import {BundleRunTerminalManager} from "./BundleRunTerminalManager";
 import {JobRunStatus} from "./JobRunStatus";
 import {AuthProvider} from "../../configuration/auth/AuthProvider";
 import {BundleRunStatus} from "./BundleRunStatus";
 import {PipelineRunStatus} from "./PipelineRunStatus";
+import {Resource, ResourceKey} from "../types";
 /**
  * This class monitors the cli bundle run output and record ids for runs. It also polls for status of the these runs.
  */
@@ -26,15 +26,17 @@ export class BundleRunStatusManager implements Disposable {
 
     getRunStatusMonitor(
         resourceKey: string,
-        resourceType: ResourceType,
+        resourceType: ResourceKey<BundleRemoteState>,
         authProvider: AuthProvider,
         resource: any
     ): BundleRunStatus {
         switch (resourceType) {
             case "jobs":
                 return new JobRunStatus(authProvider);
             case "pipelines": {
-                const id = (resource as Resource<"pipelines">[string]).id;
+                const id = (
+                    resource as Resource<BundleRemoteState, "pipelines">
+                ).id;
                 if (id === undefined) {
                     throw new Error(
                         `Pipeline id is undefined for ${resourceKey}. This likely means the pipeline is not deployed.`
@@ -48,7 +50,10 @@ export class BundleRunStatusManager implements Disposable {
         }
     }
 
-    async run(resourceKey: string, resourceType: ResourceType) {
+    async run(
+        resourceKey: string,
+        resourceType: ResourceKey<BundleRemoteState>
+    ) {
         const target = this.bundleRemoteStateModel.target;
         const authProvider = this.bundleRemoteStateModel.authProvider;
         const resource =

packages/databricks-vscode/src/bundle/run/JobRunStatus.ts

@@ -2,6 +2,7 @@
 import {
     JobsError,
     JobsRetriableError,
+    Run,
 } from "@databricks/databricks-sdk/dist/apis/jobs";
 import {Event, EventEmitter} from "vscode";
 import {AuthProvider} from "../../configuration/auth/AuthProvider";
@@ -10,7 +11,7 @@ import {BundleRunStatus} from "./BundleRunStatus";
 
 export class JobRunStatus extends BundleRunStatus {
     readonly type = "jobs";
-
+    data: Run | undefined;
     private readonly onDidCompleteEmitter = new EventEmitter<void>();
     onDidComplete: Event<void> = this.onDidCompleteEmitter.event;
 

packages/databricks-vscode/src/bundle/run/PipelineRunStatus.ts

@@ -2,9 +2,9 @@
 import {BundleRunStatus} from "./BundleRunStatus";
 import {AuthProvider} from "../../configuration/auth/AuthProvider";
 import {onError} from "../../utils/onErrorDecorator";
-import {UpdateInfoState} from "@databricks/databricks-sdk/dist/apis/pipelines";
+import {pipelines} from "@databricks/databricks-sdk";
 
-function isRunning(status?: UpdateInfoState) {
+function isRunning(status?: pipelines.UpdateInfoState) {
     if (status === undefined) {
         return false;
     }
@@ -14,7 +14,7 @@ function isRunning(status?: UpdateInfoState) {
 export class PipelineRunStatus extends BundleRunStatus {
     readonly type = "pipelines";
     private interval?: NodeJS.Timeout;
-
+    data: pipelines.GetUpdateResponse | undefined;
     constructor(
         private readonly authProvider: AuthProvider,
         private readonly pipelineId: string

packages/databricks-vscode/src/bundle/types.ts

@@ -2,3 +2,8 @@ export {type BundleSchema} from "./BundleSchema";
 import {BundleSchema} from "./BundleSchema";
 
 export type BundleTarget = Required<BundleSchema>["targets"][string];
+export type Resources<T> = T extends {resources?: infer D} ? D : never;
+export type ResourceKey<T> = keyof Resources<T>;
+export type Resource<T, K extends ResourceKey<T>> = Required<
+    Resources<T>
+>[K][keyof Required<Resources<T>>[K]];

packages/databricks-vscode/src/cli/SyncTasks.test.ts

@@ -66,7 +66,7 @@ describe(__filename, () => {
                 )
             );
             when(mockDbWorkspace.host).thenReturn(
-                Uri.parse("https://000000000000.00.azuredatabricks.net/")
+                new URL("https://000000000000.00.azuredatabricks.net/")
             );
 
             const mockSyncDestination = mock(SyncDestinationMapper);

packages/databricks-vscode/src/configuration/DatabricksWorkspace.ts

@@ -1,6 +1,6 @@
 import {WorkspaceClient, iam, logging} from "@databricks/databricks-sdk";
 import {Cluster, WorkspaceConf, WorkspaceConfProps} from "../sdk-extensions";
-import {Context, context} from "@databricks/databricks-sdk/dist/context";
+import {context, Context} from "@databricks/databricks-sdk";
 import {Uri, window, env} from "vscode";
 import {Loggers} from "../logger";
 import {workspaceConfigs} from "../vscode-objs/WorkspaceConfigs";
@@ -36,8 +36,8 @@ export class DatabricksWorkspace {
         );
     }
 
-    get host(): Uri {
-        return Uri.parse(this._authProvider.host.toString());
+    get host(): URL {
+        return this._authProvider.host;
     }
 
     get authProvider(): AuthProvider {

packages/databricks-vscode/src/extension.ts

@@ -58,7 +58,7 @@ import {OverrideableConfigModel} from "./configuration/models/OverrideableConfig
 import {BundlePreValidateModel} from "./bundle/models/BundlePreValidateModel";
 import {BundleRemoteStateModel} from "./bundle/models/BundleRemoteStateModel";
 import {BundleResourceExplorerTreeDataProvider} from "./ui/bundle-resource-explorer/BundleResourceExplorerTreeDataProvider";
-import {BundleCommands} from "./bundle/BundleCommands";
+import {BundleCommands} from "./ui/bundle-resource-explorer/BundleCommands";
 import {BundleRunTerminalManager} from "./bundle/run/BundleRunTerminalManager";
 import {BundleRunStatusManager} from "./bundle/run/BundleRunStatusManager";
 import {BundleProjectManager} from "./bundle/BundleProjectManager";
@@ -185,7 +185,8 @@ export async function activate(
     const bundleRemoteStateModel = new BundleRemoteStateModel(
         cli,
         workspaceUri,
-        workspaceConfigs
+        workspaceConfigs,
+        bundleValidateModel
     );
     const configModel = new ConfigModel(
         bundleValidateModel,
@@ -532,13 +533,13 @@ export async function activate(
         new BundleResourceExplorerTreeDataProvider(
             configModel,
             bundleRunStatusManager,
-            context
+            context,
+            connectionManager
         );
 
     const bundleCommands = new BundleCommands(
         bundleRemoteStateModel,
-        bundleRunStatusManager,
-        bundleFileWatcher
+        bundleRunStatusManager
     );
     context.subscriptions.push(
         bundleResourceExplorerTreeDataProvider,