Add a view for DABs resource viewer (#1002)

## Changes
* Add a view for DABs resource viewer. 
* The view only appears when the user has selected a valid target
* Fix some callbacks so target is updated properly when bundle file
changes.

## Tests
* manual

Author: kartikgupta-db

packages/databricks-vscode/package.json

@@ -247,6 +247,12 @@
                     "id": "configurationView",
                     "name": "Configuration"
                 },
+                {
+                    "id": "dabsResourceExplorerView",
+                    "name": "DABs Resource Explorer",
+                    "visibility": "visible",
+                    "when": "databricks.context.bundle.isTargetSet"
+                },
                 {
                     "id": "workspaceFsView",
                     "name": "Workspace explorer",

packages/databricks-vscode/src/bundle/models/BundlePreValidateModel.ts

@@ -3,8 +3,8 @@ import {BundleFileSet, BundleWatcher} from "..";
 import {BundleTarget} from "../types";
 import {BaseModelWithStateCache} from "../../configuration/models/BaseModelWithStateCache";
 import {UrlUtils} from "../../utils";
-import {onError} from "../../utils/onErrorDecorator";
 import {Mutex} from "../../locking";
+import {onError} from "../../utils/onErrorDecorator";
 
 export type BundlePreValidateState = {
     host?: URL;
@@ -56,14 +56,16 @@ export class BundlePreValidateModel extends BaseModelWithStateCache<BundlePreVal
     }
 
     protected readStateFromTarget(
-        target: BundleTarget
-    ): BundlePreValidateState {
-        return {
-            ...target,
-            host: UrlUtils.normalizeHost(target?.workspace?.host ?? ""),
-            mode: target?.mode as BundlePreValidateState["mode"],
-            authParams: undefined,
-        };
+        target?: BundleTarget
+    ): BundlePreValidateState | undefined {
+        return target
+            ? {
+                  ...target,
+                  host: UrlUtils.normalizeHost(target?.workspace?.host ?? ""),
+                  mode: target?.mode as BundlePreValidateState["mode"],
+                  authParams: undefined,
+              }
+            : undefined;
     }
 
     @onError({popup: {prefix: "Failed to parse bundle yaml"}})
@@ -76,7 +78,7 @@ export class BundlePreValidateModel extends BaseModelWithStateCache<BundlePreVal
         const targetObject = (await this.bundleFileSet.bundleDataCache.value)
             .targets?.[this.target];
 
-        return this.readStateFromTarget(targetObject ?? {});
+        return this.readStateFromTarget(targetObject) ?? {};
     }
 
     public async getFileToWrite(key: string) {

packages/databricks-vscode/src/bundle/models/BundleValidateModel.ts

@@ -4,7 +4,6 @@ import {AuthProvider} from "../../configuration/auth/AuthProvider";
 import {Mutex} from "../../locking";
 import {CliWrapper} from "../../cli/CliWrapper";
 import {BundleTarget} from "../types";
-import {onError} from "../../utils/onErrorDecorator";
 import lodash from "lodash";
 import {workspaceConfigs} from "../../vscode-objs/WorkspaceConfigs";
 import {BaseModelWithStateCache} from "../../configuration/models/BaseModelWithStateCache";

packages/databricks-vscode/src/configuration/ConnectionManager.ts

@@ -107,7 +107,8 @@ export class ConnectionManager implements Disposable {
     constructor(
         private cli: CliWrapper,
         private readonly configModel: ConfigModel,
-        private readonly workspaceUri: Uri
+        private readonly workspaceUri: Uri,
+        private readonly customWhenContext: CustomWhenContext
     ) {}
 
     public async init() {
@@ -330,7 +331,7 @@ export class ConnectionManager implements Disposable {
             this._state = newState;
             this.onDidChangeStateEmitter.fire(this._state);
         }
-        CustomWhenContext.setLoggedIn(this._state === "CONNECTED");
+        this.customWhenContext.setLoggedIn(this._state === "CONNECTED");
     }
 
     async startCluster() {

packages/databricks-vscode/src/configuration/models/ConfigModel.ts

@@ -17,6 +17,7 @@ import {
     BundleValidateModel,
     BundleValidateState,
 } from "../../bundle/models/BundleValidateModel";
+import {CustomWhenContext} from "../../vscode-objs/CustomWhenContext";
 
 const defaults: ConfigState = {
     mode: "development",
@@ -119,6 +120,7 @@ export class ConfigModel implements Disposable {
         public readonly bundleValidateModel: BundleValidateModel,
         public readonly overrideableConfigModel: OverrideableConfigModel,
         public readonly bundlePreValidateModel: BundlePreValidateModel,
+        private readonly vscodeWhenContext: CustomWhenContext,
         private readonly stateStorage: StateStorage
     ) {
         this.disposables.push(
@@ -183,15 +185,10 @@ export class ConfigModel implements Disposable {
         }
 
         if (
-            this.target !== undefined &&
-            !(
-                this.target in
-                ((await this.bundlePreValidateModel.targets) ?? {})
-            )
+            target !== undefined &&
+            !(target in ((await this.bundlePreValidateModel.targets) ?? {}))
         ) {
-            throw new Error(
-                `Target '${this.target}' doesn't exist in the bundle`
-            );
+            throw new Error(`Target '${target}' doesn't exist in the bundle`);
         }
         await this.configsMutex.synchronise(async () => {
             this._target = target;
@@ -207,6 +204,8 @@ export class ConfigModel implements Disposable {
             });
             this.onDidChangeTargetEmitter.fire();
         });
+
+        this.vscodeWhenContext.isTargetSet(this._target !== undefined);
     }
 
     @onError({popup: {prefix: "Failed to set auth provider."}})

packages/databricks-vscode/src/configuration/models/OverrideableConfigModel.ts

@@ -1,7 +1,6 @@
 import {StateStorage} from "../../vscode-objs/StateStorage";
 import {Mutex} from "../../locking";
 import {BaseModelWithStateCache} from "./BaseModelWithStateCache";
-import {onError} from "../../utils/onErrorDecorator";
 
 export type OverrideableConfigState = {
     authProfile?: string;

packages/databricks-vscode/src/extension.ts

@@ -59,10 +59,12 @@ import {ConfigModel} from "./configuration/models/ConfigModel";
 import {OverrideableConfigModel} from "./configuration/models/OverrideableConfigModel";
 import {BundlePreValidateModel} from "./bundle/models/BundlePreValidateModel";
 
+const customWhenContext = new CustomWhenContext();
+
 export async function activate(
     context: ExtensionContext
 ): Promise<PublicApi | undefined> {
-    CustomWhenContext.setActivated(false);
+    customWhenContext.setActivated(false);
 
     if (extensions.getExtension("databricks.databricks-vscode") !== undefined) {
         await commands.executeCommand(
@@ -142,8 +144,8 @@ export async function activate(
 
     // manage contexts for experimental features
     function updateFeatureContexts() {
-        CustomWhenContext.updateShowClusterView();
-        CustomWhenContext.updateShowWorkspaceView();
+        customWhenContext.updateShowClusterView();
+        customWhenContext.updateShowWorkspaceView();
     }
 
     updateFeatureContexts();
@@ -180,13 +182,15 @@ export async function activate(
         bundleValidateModel,
         overrideableConfigModel,
         bundlePreValidateModel,
+        customWhenContext,
         stateStorage
     );
 
     const connectionManager = new ConnectionManager(
         cli,
         configModel,
-        workspaceUri
+        workspaceUri,
+        customWhenContext
     );
     context.subscriptions.push(
         connectionManager.onDidChangeState(async (state) => {
@@ -607,7 +611,7 @@ export async function activate(
     connectionManager.init().catch((e) => {
         window.showErrorMessage(e);
     });
-    CustomWhenContext.setActivated(true);
+    customWhenContext.setActivated(true);
     telemetry.recordEvent(Events.EXTENSION_ACTIVATED);
 
     const publicApi: PublicApi = {
@@ -619,5 +623,5 @@ export async function activate(
 
 // this method is called when your extension is deactivated
 export function deactivate() {
-    CustomWhenContext.setActivated(false);
+    customWhenContext.setActivated(false);
 }

packages/databricks-vscode/src/vscode-objs/CustomWhenContext.ts

@@ -2,22 +2,30 @@ import {commands} from "vscode";
 import {workspaceConfigs} from "./WorkspaceConfigs";
 
 // eslint-disable-next-line @typescript-eslint/naming-convention
-export const CustomWhenContext = {
+export class CustomWhenContext {
     setLoggedIn(value: boolean) {
         commands.executeCommand(
             "setContext",
             "databricks.context.loggedIn",
             value
         );
-    },
+    }
 
     setActivated(value: boolean) {
         commands.executeCommand(
             "setContext",
             "databricks.context.activated",
             value
         );
-    },
+    }
+
+    isTargetSet(value: boolean) {
+        commands.executeCommand(
+            "setContext",
+            "databricks.context.bundle.isTargetSet",
+            value
+        );
+    }
 
     updateShowClusterView() {
         commands.executeCommand(
@@ -27,7 +35,7 @@ export const CustomWhenContext = {
                 "views.cluster"
             )
         );
-    },
+    }
 
     updateShowWorkspaceView() {
         commands.executeCommand(
@@ -37,5 +45,5 @@ export const CustomWhenContext = {
                 "views.workspace"
             )
         );
-    },
-};
+    }
+}