Fix creation of .ide if it doesn't exists (#585)

Author: kartikgupta-db

packages/databricks-sdk-js/src/services/wsfs/WorkspaceFsDir.ts

@@ -1,5 +1,4 @@
 import {posix} from "path";
-import {ApiClientResponseError} from "../../api-client";
 import {Context, context} from "../../context";
 import {WorkspaceFsEntity} from ".";
 import {ExposedLoggers, withLogContext} from "../../logging";
@@ -45,8 +44,8 @@ export class WorkspaceFsDir extends WorkspaceFsEntity {
             await this._workspaceFsService.mkdirs({path: validPath});
         } catch (e: unknown) {
             let err: any = e;
-            if (e instanceof ApiClientResponseError) {
-                if (e.error_code === "RESOURCE_ALREADY_EXISTS") {
+            if (e instanceof Error) {
+                if (e.message.includes("RESOURCE_ALREADY_EXISTS")) {
                     err = new Error(
                         `Can't create ${path} as child of ${this.path}: A file with same path exists`
                     );

packages/databricks-sdk-js/src/services/wsfs/WorkspaceFsEntity.ts

@@ -155,8 +155,8 @@ export abstract class WorkspaceFsEntity {
             return entity;
         } catch (e) {
             if (
-                e instanceof ApiClientResponseError &&
-                e.error_code === "RESOURCE_DOES_NOT_EXIST"
+                e instanceof Error &&
+                e.message.includes("RESOURCE_DOES_NOT_EXIST")
             ) {
                 return undefined;
             }

packages/databricks-vscode/src/configuration/ConnectionCommands.ts

@@ -1,8 +1,4 @@
-import {
-    Cluster,
-    WorkspaceFsEntity,
-    WorkspaceFsUtils,
-} from "@databricks/databricks-sdk";
+import {Cluster, WorkspaceFsEntity} from "@databricks/databricks-sdk";
 import {homedir} from "node:os";
 import {
     Disposable,
@@ -217,25 +213,10 @@ export class ConnectionCommands implements Disposable {
                 return;
             }
 
-            let rootDir = await WorkspaceFsEntity.fromPath(
+            const rootDir = await WorkspaceFsEntity.fromPath(
                 wsClient,
                 rootDirPath.path
             );
-            if (!rootDir && workspaceConfigs.enableFilesInWorkspace) {
-                const meDir = await WorkspaceFsEntity.fromPath(
-                    wsClient,
-                    `/Users/${me}`
-                );
-                if (WorkspaceFsUtils.isDirectory(meDir)) {
-                    rootDir = await meDir.mkdir(rootDirPath.path);
-                }
-                if (!rootDir) {
-                    window.showErrorMessage(
-                        `Can't find or create ${rootDirPath}`
-                    );
-                    return;
-                }
-            }
 
             type WorkspaceFsQuickPickItem = QuickPickItem & {
                 path?: string;

packages/databricks-vscode/src/configuration/ConnectionManager.ts

@@ -1,4 +1,9 @@
-import {WorkspaceClient, Cluster} from "@databricks/databricks-sdk";
+import {
+    WorkspaceClient,
+    Cluster,
+    WorkspaceFsEntity,
+    WorkspaceFsUtils,
+} from "@databricks/databricks-sdk";
 import {
     env,
     EventEmitter,
@@ -202,9 +207,46 @@ export class ConnectionManager {
             this.updateSyncDestination(undefined);
         }
 
+        if (
+            this.databricksWorkspace &&
+            workspaceConfigs.enableFilesInWorkspace
+        ) {
+            await this.createRootDirectory(
+                workspaceClient,
+                this.databricksWorkspace.currentFsRoot,
+                this.databricksWorkspace.userName
+            );
+        }
+
         this.updateState("CONNECTED");
     }
 
+    async createRootDirectory(
+        wsClient: WorkspaceClient,
+        rootDirPath: RemoteUri,
+        me: string
+    ) {
+        let rootDir = await WorkspaceFsEntity.fromPath(
+            wsClient,
+            rootDirPath.path
+        );
+        if (!rootDir) {
+            const meDir = await WorkspaceFsEntity.fromPath(
+                wsClient,
+                `/Users/${me}`
+            );
+            if (WorkspaceFsUtils.isDirectory(meDir)) {
+                rootDir = await meDir.mkdir(rootDirPath.path);
+            }
+            if (!rootDir) {
+                window.showErrorMessage(
+                    `Can't find or create ${rootDirPath.path}`
+                );
+                return;
+            }
+        }
+    }
+
     async logout() {
         if (this._state === "DISCONNECTED") {
             return;

packages/databricks-vscode/src/workspace-fs/WorkspaceFsWorkflowWrapper.test.ts

@@ -124,7 +124,11 @@ describe(__filename, async () => {
                     anything()
                 )
             ).thenThrow(
-                new ApiClientResponseError("", {}, "RESOURCE_DOES_NOT_EXIST")
+                new ApiClientResponseError(
+                    "RESOURCE_DOES_NOT_EXIST",
+                    {},
+                    "RESOURCE_DOES_NOT_EXIST"
+                )
             );
 
             when(
@@ -202,7 +206,11 @@ describe(__filename, async () => {
                     anything()
                 )
             ).thenThrow(
-                new ApiClientResponseError("", {}, "RESOURCE_DOES_NOT_EXIST")
+                new ApiClientResponseError(
+                    "RESOURCE_DOES_NOT_EXIST",
+                    {},
+                    "RESOURCE_DOES_NOT_EXIST"
+                )
             );
 
             when(