Skip to content

Commit cee580c

Browse files
authored
Hard code VSCode version for e2e testing (#58)
As vscode-extension-tester is very sensitive to VSCode versions
1 parent 9e75eff commit cee580c

File tree

5 files changed

+58
-461
lines changed

5 files changed

+58
-461
lines changed

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@
2929
"homepage": "https://github.com/databricks/databricks-vscode#readme",
3030
"packageManager": "yarn@3.2.1",
3131
"devDependencies": {
32-
"@typescript-eslint/eslint-plugin": "^5.31.0",
33-
"@typescript-eslint/parser": "^5.31.0",
34-
"eslint": "^8.20.0",
32+
"@typescript-eslint/eslint-plugin": "^5.32.0",
33+
"@typescript-eslint/parser": "^5.32.0",
34+
"eslint": "^8.21.0",
3535
"eslint-config-prettier": "^8.5.0",
3636
"typescript": "^4.7.4"
3737
}

packages/databricks-sdk-js/package.json

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,11 @@
3636
"@istanbuljs/nyc-config-typescript": "^1.0.2",
3737
"@types/ini": "^1.3.31",
3838
"@types/mocha": "^9.1.1",
39-
"@types/node": "^18.6.3",
39+
"@types/node": "^18.6.4",
4040
"@types/node-fetch": "^2.6.2",
4141
"@types/tmp": "^0.2.3",
4242
"@types/uuid": "^8.3.4",
43-
"eslint": "^8.20.0",
43+
"eslint": "^8.21.0",
4444
"mocha": "^10.0.0",
4545
"nyc": "^15.1.0",
4646
"prettier": "^2.7.1",
@@ -49,8 +49,7 @@
4949
"ts-mocha": "^10.0.0",
5050
"ts-node": "^10.9.1",
5151
"typescript": "^4.7.4",
52-
"uuid": "^8.3.2",
53-
"webpack": "^5.73.0"
52+
"uuid": "^8.3.2"
5453
},
5554
"nyc": {
5655
"extends": "@istanbuljs/nyc-config-typescript",

packages/databricks-vscode/package.json

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"license": "Apache-2.0",
77
"version": "0.0.1",
88
"engines": {
9-
"vscode": "^1.69.0"
9+
"vscode": "^1.69.1"
1010
},
1111
"categories": [
1212
"Data Science",
@@ -216,7 +216,7 @@
216216
"fix": "prettier . --write",
217217
"test:lint": "eslint src --ext ts && prettier . -c",
218218
"test:unit": "yarn run compile && node ./out/test/runTest.js",
219-
"test:integ:prepare": "yarn run package && extest get-vscode --type ${VSCODE_TEST_VERSION:-stable} --storage /tmp/vscode-test-databricks && extest get-chromedriver --storage /tmp/vscode-test-databricks && extest install-vsix -f databricks-0.0.1.vsix --storage /tmp/vscode-test-databricks",
219+
"test:integ:prepare": "yarn run package && extest get-vscode --code_version 1.69.1 --storage /tmp/vscode-test-databricks && extest get-chromedriver --storage /tmp/vscode-test-databricks && extest install-vsix -f databricks-0.0.1.vsix --storage /tmp/vscode-test-databricks",
220220
"test:integ:run": "yarn run compile && node out/test/e2e/scripts/e2e.js --storage /tmp/vscode-test-databricks --code_settings src/test/e2e/settings.json 'out/**/*.e2e.js'",
221221
"test:integ": "yarn run test:integ:prepare && yarn run test:integ:run",
222222
"test:cov": "nyc yarn run test:unit",
@@ -231,14 +231,14 @@
231231
"@istanbuljs/nyc-config-typescript": "^1.0.2",
232232
"@types/glob": "^7.2.0",
233233
"@types/mocha": "^9.1.1",
234-
"@types/node": "^18.0.6",
234+
"@types/node": "^18.6.4",
235235
"@types/tmp": "^0.2.3",
236-
"@types/vscode": "^1.69.0",
237-
"@typescript-eslint/eslint-plugin": "^5.30.7",
236+
"@types/vscode": "^1.69.1",
237+
"@typescript-eslint/eslint-plugin": "^5.32.0",
238238
"@typescript-eslint/parser": "^5.32.0",
239239
"@vscode/test-electron": "^2.1.5",
240-
"esbuild": "^0.14.51",
241-
"eslint": "^8.20.0",
240+
"esbuild": "^0.14.53",
241+
"eslint": "^8.21.0",
242242
"glob": "^8.0.3",
243243
"mocha": "^10.0.0",
244244
"nyc": "^15.1.0",
@@ -247,7 +247,7 @@
247247
"ts-mockito": "^2.6.1",
248248
"typescript": "^4.7.4",
249249
"vsce": "^2.10.0",
250-
"vscode-extension-tester": "^4.3.0"
250+
"vscode-extension-tester": "^4.4.0"
251251
},
252252
"nyc": {
253253
"extends": "@istanbuljs/nyc-config-typescript",
@@ -267,4 +267,4 @@
267267
],
268268
"report-dir": "coverage"
269269
}
270-
}
270+
}

packages/databricks-vscode/src/test/e2e/configure.e2e.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,19 +5,13 @@ import * as tmp from "tmp-promise";
55
import {
66
VSBrowser,
77
WebDriver,
8-
ActivityBar,
98
InputBox,
109
Workbench,
1110
TreeItem,
1211
ContextMenu,
1312
CustomTreeSection,
1413
} from "vscode-extension-tester";
15-
import {
16-
getViewSection,
17-
openCommandPrompt,
18-
openFolder,
19-
waitForTreeItems,
20-
} from "./utils";
14+
import {getViewSection, openFolder, waitForTreeItems} from "./utils";
2115

2216
describe("Configure Databricks Extension", function () {
2317
// these will be populated by the before() function

0 commit comments

Comments
 (0)