[DECO-150] Show proper error message if no sync destination when running file (#141)

https://user-images.githubusercontent.com/88345179/198275420-0636faf4-583b-4901-9608-c3d12f3bed7b.mov

Author: kartikgupta-db

packages/databricks-vscode/src/configuration/ConnectionCommands.ts

@@ -1,5 +1,6 @@
 import {Cluster, Repo} from "@databricks/databricks-sdk";
 import {homedir} from "node:os";
+import {resolve} from "node:path";
 import {
     Disposable,
     QuickPickItem,
@@ -184,18 +185,24 @@ export class ConnectionCommands implements Disposable {
             }));
             quickPick.busy = false;
 
-            quickPick.onDidAccept(async () => {
-                const repoPath = quickPick.selectedItems[0].path;
-                await this.connectionManager.attachSyncDestination(
-                    Uri.from({
-                        scheme: "dbws",
-                        path: repoPath,
-                    })
-                );
-                quickPick.dispose();
-            });
+            await new Promise<void>((resolve) => {
+                quickPick.onDidAccept(async () => {
+                    const repoPath = quickPick.selectedItems[0].path;
+                    await this.connectionManager.attachSyncDestination(
+                        Uri.from({
+                            scheme: "dbws",
+                            path: repoPath,
+                        })
+                    );
+                    quickPick.dispose();
+                    resolve();
+                });
 
-            quickPick.onDidHide(() => quickPick.dispose());
+                quickPick.onDidHide(() => {
+                    quickPick.dispose();
+                    resolve();
+                });
+            });
         };
     }
 

packages/databricks-vscode/src/run/DabaricksRuntime.ts

@@ -14,7 +14,7 @@ import {
 
 import {SyncDestination} from "../configuration/SyncDestination";
 import {ConnectionManager} from "../configuration/ConnectionManager";
-import {promptForClusterStart} from "../ui/prompts";
+import {promptForClusterStart} from "./prompts";
 import {CodeSynchronizer} from "../sync/CodeSynchronizer";
 
 export interface OutputEvent {

packages/databricks-vscode/src/run/DabaricksWorkflowDebugAdapter.ts

@@ -24,7 +24,7 @@ import {DebugProtocol} from "@vscode/debugprotocol";
 import {ConnectionManager} from "../configuration/ConnectionManager";
 import {Subject} from "./Subject";
 import {runAsWorkflow} from "./WorkflowOutputPanel";
-import {promptForClusterStart} from "../ui/prompts";
+import {promptForClusterStart} from "./prompts";
 import {CodeSynchronizer} from "../sync/CodeSynchronizer";
 
 /**

packages/databricks-vscode/src/run/RunCommands.ts

@@ -1,5 +1,7 @@
+import {resolve} from "path";
 import {commands, debug, Uri, window} from "vscode";
 import {ConnectionManager} from "../configuration/ConnectionManager";
+import {promptForAttachingSyncDest} from "./prompts";
 import {isNotebook} from "../utils";
 
 /**
@@ -26,6 +28,20 @@ export class RunCommands {
                     await this.connection.waitForConnect();
                 }
 
+                if (this.connection.syncDestination === undefined) {
+                    await promptForAttachingSyncDest(async () => {
+                        window.showErrorMessage(
+                            "Execution cancelled because no Databricks Repo is attached"
+                        );
+                    });
+                    if (this.connection.syncDestination === undefined) {
+                        window.showErrorMessage(
+                            "Execution cancelled because no Databricks Repo is attached"
+                        );
+                        return;
+                    }
+                }
+
                 await commands.executeCommand("databricks.sync.start");
                 await debug.startDebugging(
                     undefined,
@@ -52,6 +68,20 @@ export class RunCommands {
                     await this.connection.waitForConnect();
                 }
 
+                if (this.connection.syncDestination === undefined) {
+                    await promptForAttachingSyncDest(async () => {
+                        window.showErrorMessage(
+                            "Execution cancelled because no Databricks Repo is attached"
+                        );
+                    });
+                    if (this.connection.syncDestination === undefined) {
+                        window.showErrorMessage(
+                            "Execution cancelled because no Databricks Repo is attached"
+                        );
+                        return;
+                    }
+                }
+
                 await commands.executeCommand("databricks.sync.start");
                 await debug.startDebugging(
                     undefined,

packages/databricks-vscode/src/ui/prompts.ts renamed to packages/databricks-vscode/src/run/prompts.ts

@@ -10,17 +10,39 @@ export async function promptForClusterStart(
         const response = await window.showErrorMessage(
             "The attached cluster is not running.",
             "Start Cluster",
-            "Cancel Execution"
+            "Cancel"
         );
         switch (response) {
             case "Start Cluster":
                 await onAccept();
                 await commands.executeCommand("databricks.cluster.start");
                 return true;
-            case "Cancel Execution":
+            case "Cancel":
                 await onReject();
                 return false;
         }
     }
     return true;
 }
+
+export async function promptForAttachingSyncDest(
+    onReject: () => Promise<void>,
+    onAccept: () => Promise<void> = async () => {}
+) {
+    const response = await window.showErrorMessage(
+        "Please configure a Databricks Repo for syncing",
+        "Attach Repo",
+        "Cancel"
+    );
+    switch (response) {
+        case "Attach Repo":
+            await commands.executeCommand(
+                "databricks.connection.attachSyncDestination"
+            );
+            await onAccept();
+            return true;
+        case "Cancel":
+            await onReject();
+            return false;
+    }
+}