Fix project.json file watcher rewriting profile bug (#125)

To reproduce
- Configure both profile and cluster
- Delete both from the project.json file and save the file
- Profile will be written back

This PR fixes this behaviour.

Author: kartikgupta-db

packages/databricks-vscode/src/configuration/ConnectionManager.ts

@@ -165,10 +165,11 @@ export class ConnectionManager {
             await this.waitForConnect();
         }
 
+        this._projectConfigFile = undefined;
         this._apiClient = undefined;
         this._me = undefined;
-        this._projectConfigFile = undefined;
         this.updateCluster(undefined);
+        this.updateSyncDestination(undefined);
         this.updateState("DISCONNECTED");
     }
 
@@ -301,6 +302,9 @@ export class ConnectionManager {
     }
 
     private updateState(newState: ConnectionState) {
+        if (newState === "DISCONNECTED") {
+            this._profile = undefined;
+        }
         if (this._state !== newState) {
             this._state = newState;
             this.onDidChangeStateEmitter.fire(this._state);

packages/databricks-vscode/src/configuration/ProjectConfigFileWatcher.ts

@@ -16,39 +16,41 @@ export class ProjectConfigFileWatcher implements Disposable {
             fileSystemWatcher,
             fileSystemWatcher.onDidCreate(async (e) => {
                 if (connectionManager.state !== "CONNECTED") {
-                    connectionManager.login();
+                    await connectionManager.login();
                 }
             }, this),
             fileSystemWatcher.onDidChange(async (e) => {
                 const configFile = await ProjectConfigFile.load(rootPath);
                 if (configFile.profile !== connectionManager.profile) {
-                    connectionManager.login();
+                    await connectionManager.login();
                 }
                 if (connectionManager.cluster?.id !== configFile.clusterId) {
                     if (configFile.clusterId) {
-                        connectionManager.attachCluster(configFile.clusterId);
+                        await connectionManager.attachCluster(
+                            configFile.clusterId
+                        );
                     } else {
-                        connectionManager.detachCluster();
+                        await connectionManager.detachCluster();
                     }
                 }
                 if (
                     connectionManager.syncDestination?.path.path !==
                     configFile.workspacePath
                 ) {
                     if (configFile.workspacePath) {
-                        connectionManager.attachSyncDestination(
+                        await connectionManager.attachSyncDestination(
                             Uri.from({
                                 scheme: "dbws",
                                 path: configFile.workspacePath,
                             })
                         );
                     } else {
-                        connectionManager.detachSyncDestination();
+                        await connectionManager.detachSyncDestination();
                     }
                 }
             }, this),
-            fileSystemWatcher.onDidDelete((e) => {
-                connectionManager.logout();
+            fileSystemWatcher.onDidDelete(async (e) => {
+                await connectionManager.logout();
             }, this)
         );
     }