Profiles dir overwritten in the code for DBT version < 1.3.0

[sebaap]

Describe the bug
The profiles dir is being overwritten in the code (this lines) after passed as an argument.
If I execute:
data_diff --dbt --dbt-profiles-dir my/custom/dir
Then I get
ERROR No profile 'my_dbt_profile' found in '/Users/myuser/.dbt/profiles.yml'

I'm guessing this is not the intended behaviour as I believe the argument should take precedence in this case.

Describe the environment

I'm using the master branch of this repo (v0.7.14) and DBT v1.2.6 but i guess any < 1.3.0 will have this issue

[sebaap]

happy to submit a PR if someone confirms this is a bug and help is needed btw

[dlawin]

happy to submit a PR if someone confirms this is a bug and help is needed btw

Good catch @sebaap, this is not intended. The ~intent~ is to follow the default profiles.yml location based on dbt version, but for the flag to take precedence.

        if dbt_version < parse_version("1.3.0"):
            self.profiles_dir = legacy_profiles_dir()

I think it makes sense to pull this out of the method and into the class __init__ and conditionally set it there based on dbt_version + the presence of profiles_dir_override

The dbt version is available there

We'd appreciate the contribution if you have time! Assigning this to you but lmk if you need to hand it off

[dlawin]

One other thing to keep in mind is this env_var