Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Oracle: Added support for schemas (Issue #115) #117

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Oracle: Added support for schemas (Issue #115) #117

merged 2 commits into from
Jun 28, 2022

Conversation

erezsh
Copy link
Contributor

@erezsh erezsh commented Jun 28, 2022

No description provided.

Copy link
Contributor

@sirupsen sirupsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Another problem he seemed to have was concat not supporting just 1 argument in Oracle, can you add this patch too to sql.py?

    def compile(self, c: Compiler):
        compiled_exprs = ", ".join(map(c.compile, self.exprs))
        expr = compiled_exprs
        if len(self.exprs) > 1:
            expr = f"concat({compiled_exprs})"
        md5 = c.database.md5_to_int(expr)
        return f"sum({md5})"

@erezsh erezsh merged commit 5fdd257 into master Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants