This repository was archived by the owner on May 17, 2024. It is now read-only.
Update __init__.py #211
Closed
Update __init__.py #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since not all tables have the column "id", this should be changed to use the key_column specified in the retrieval of the dataset
|
This code won't work, for several reasons. |
|
But yes, we need to fix this function, so the defaults won't override the given values. Thanks for bringing it to my attention. |
|
You're welcome, it's a great project and I'd like to help in any way I can. |
erezsh
added a commit
that referenced
this pull request
Aug 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since not all tables have the column "id", this should be changed to use the key_column specified in the retrieval of the dataset