This repository was archived by the owner on May 17, 2024. It is now read-only.
Duckdb driver for Issue #176 #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Read the docstring, you need to implement It may pass your local tests, but if you test it vs Snowflake it will fail otherwise. |
|
You're changing a lot of lines you're not supposed to touch, mostly with whitespace - https://github.com/datafold/data-diff/pull/276/files And I don't think |
|
Ran black -l 120. Removed test_duckdb.py |
erezsh
suggested changes
Nov 10, 2022
|
@jardayn I tried to run this locally and got this error: Test: test_types_duckdb_bigint_duckdb_bigint_50 |
|
Waiting on DuckDB 0.6.0. that'll bring HEX to int conversions. |
erezsh
suggested changes
Nov 15, 2022
Added MD5 to Int for DDB Upped the amount of queries for the test Normalization Dialect + Match Path No more match path Now DDB is part of the tests Trying to get tests to work More debugging of tests More types Tests work! cleanup fixed conflict Added Boolean tests to DDB Added Boolean tests to DDB black -l 120 formatting Removed test_duckdb Reverting formatting Review comments Review comments 0.6.0. DDB! TSTZ tests for DDB fixed Tests for DDB work changed how test_cli gets the current TZ Review comments reverting changes to test_cli
|
Thank you for contributing! 🥳 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#176