This repository was archived by the owner on May 17, 2024. It is now read-only.
Simplify JSON column types #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolar
referenced
this pull request
in nicolasaldecoa/sqeleton
May 3, 2023
…port Add support for column types: PostgreSQL JSON/JSONB and RedShift Super
nolar
force-pushed
the
simplify-json-columns
branch
from
74edbcb to
c2c5102
Compare
dlawin
approved these changes
May 5, 2023
added 3 commits
May 5, 2023 21:08
We know that all these classes are column types, there is no need to specify that. Also to consistency with other column types.
nolar
force-pushed
the
simplify-json-columns
branch
from
c2c5102 to
46c8867
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick follow-up on #543 to simplify JSON column types before it is released.
In #533, similar types will follow —
Struct&Array.But we should better not bind these changes by time.