This repository was archived by the owner on May 17, 2024. It is now read-only.
Hotfix: Correct early return in diffs_are_equiv_jsons not including the set object #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasaldecoa
changed the title
dlawin
approved these changes
May 5, 2023
nolar
approved these changes
May 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Current version is broken, when calling
utils.diffs_are_equiv_jsons,hashdiff_tables.diff_setsis expecting to have always 2 values to unpack and the early return in the function outputs a single boolean.When adding the warning feature, I forgot to change the early return to match the function's signature.