This repository was archived by the owner on May 17, 2024. It is now read-only.
add support for custom database config #586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlawin
added
enhancement
kylemcnair
approved these changes
May 18, 2023
pik94
approved these changes
May 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #483
It's possible to set databases in model configs or model .yml, use this value for the "prod database" when it is present, otherwise fall back to the existing logic.
Old:
config db > dev db
New:
custom db > config db > dev db
Added new unit test
test_get_diff_vars_custom_dbto verifymodel.config.databaseis used for prod_path when present.