This repository was archived by the owner on May 17, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 294
add json format for dbt diff values #612
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlawin
reviewed
Jun 14, 2023
I'm getting an exception
|
@dlawin forgot that those type hints were not supported by the older versions of Python. I just pushed a fix. |
600680d
to
da572c1
Compare
I'm seeing this when I run against it the test project:
|
@dlawin I've added a fix for the exception you mentioned, thanks for the hint how to solve it 🙇 |
dlawin
approved these changes
Jun 21, 2023
Resolves #607 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--json-output
parameter support for dbt diffs. See type hints indata_diff/format.py
andtests/test_format.py
for documentation of the format.Main things to discuss @nolar @dagadbm