Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

include only rows with equal PK to values diff stats in --json output #631

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

vvkh
Copy link
Contributor

@vvkh vvkh commented Jun 28, 2023

We used to count differences across all rows for the "diffCounts" metric, even added/removed rows, for --json output format. Replaced that with extra_column_diffs value — the one we currently use for normal output.

Normal output
image

--json

{
  "status": "success", 
  "result": "different", 
  "model": "model.dbt_valentin_snowflake.downstream_different_from_row_diff", ..., 
  "stats": {"diffCounts": {"VALUE": 3}}},
  ...
}

@vvkh vvkh requested review from leoebfolsom and dlawin June 28, 2023 15:04
@vvkh vvkh force-pushed the json-values-diff-stats-fix branch from 9204abd to d1afc17 Compare June 28, 2023 15:29
@dlawin dlawin merged commit e1ce08f into master Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants