This repository has been archived by the owner on May 17, 2024. It is now read-only.
Switch from cx_Oracle to oracledb
#681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cx_Oracle` is officially deprecated since 2021 (2 years go) and no new released were made. The new official library is `oracledb`. This warning is the first sentence in cx_Oracle's docs.
New projects, such as data-diff, should use the new library. Luckily, `oracledb` is mostly a drop-in replacement for `cx_Oracle`, so no code changes are needed.
Besides, `oracledb` provides 2 modes: the "thin" mode and the "thick" mode. The latter (`"thick") one requires binary libraries, the former one ("thin") works in pure Python. This simplifies the Oracle usage for users.
sungchun12
reviewed
Aug 15, 2023
|
Quick chatgpt reference. May be worth adding thick mode into Datafold for xdb data diffing if thick mode has a significant performance boost.
|
dlawin
approved these changes
Aug 22, 2023
|
Hello @dlawin |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cx_Oracleis officially deprecated since 2021 (2 years go) and no new released were made. The new official library isoracledb. This warning is the first sentence in cx_Oracle's docs.New projects, such as data-diff, should use the new library. Luckily,
oracledbis mostly a drop-in replacement forcx_Oracle, so no code changes are needed.Besides,
oracledbprovides 2 modes: the "thin" mode and the "thick" mode. The latter (`"thick") one requires binary libraries, the former one ("thin") works in pure Python. This simplifies the Oracle usage for users.