This repository was archived by the owner on May 17, 2024. It is now read-only.
Remove UUID-type inference for textual columns #852
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to be 100% sure that all the values in a textual column are valid UUIDs if we want to treat it as native UUID. Otherwise, the diff may crash when we are converting an invalid UUID to a number. Therefore, inferring the UUID type from a sample is not reliable enough. The PR removes the inference.
Only 1 potential case is affected, when a native UUID column is being compared with a textual column with UUID strings. This won't work out of the box anymore, but it will still be possible with explicit cast in a view. Other cases are covered by alphanumeric PK support.
Before the change
After the change