Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate workflow-calcium-imaging's tutorial environment, notebooks, and tests #135

Merged
merged 680 commits into from
Jun 7, 2023

Conversation

kabilar
Copy link
Collaborator

@kabilar kabilar commented May 22, 2023

Description

  • The workflow-calcium-imaging repository provides a tutorial environment and notebooks (and pytests) for running element-calcium-imaging.
  • In the proposed changes, we integrate the contents of workflow-calcium-imaging into element-calcium-imaging, and will subsequently archive workflow-calcium-imaging.

Changes

  • Use git merge to merge the workflow-calcium-imaging git history into element-calcium-imaging
  • Subsequently made the following updates
    • Update version and changelog
    • Update setup.py
      • Add extras_require feature
      • Move installation of sbxreader and scanreader to the Dockerfile so that element-calcium-imaging can be published to PyPI.
    • Update Dev Container
      • Update Dockerfile to install all extras_require for element-calcium-imaging
      • Rename docker-compose.yaml to docker-compose-db.yaml
    • Update GitHub Actions
      • Replace previous workflows with reusable workflows in the datajoint/.github repository for GitHub, PyPI, and MkDocs releases
      • Add workflow to build and publish Dev Container Docker image
      • Add tests to ensure black formatter compliance
    • Update imaging* and scan schemas with backwards incompatible change to simplify user experience
      • Add get_image_files function and replace get_nd2_files, get_prairieview_files, get_scan_box_files, get_scan_image_files.
    • Update docs
      • workflow -> pipeline
    • Update notebooks
      • Add tutorial_pipeline script to import and activate schemas
      • reference.Equipment -> lab.Device
      • Remove demo_prepare.ipynb, which can be replaced by tutorial.ipynb
      • Rename demo_run.ipynb to demo.ipynb
    • element_calcium_imaging/__init__.py now uses environment variables (if available) in place of dj.config['custom'] values
    • Update tests

@kabilar kabilar marked this pull request as ready for review June 7, 2023 03:42
@kabilar kabilar changed the title Merge workflow-calcium-imaging Integrate workflow-calcium-imaging tutorial environment, notebooks, and tests Jun 7, 2023
@kabilar kabilar changed the title Integrate workflow-calcium-imaging tutorial environment, notebooks, and tests Integrate workflow-calcium-imaging's tutorial environment, notebooks, and tests Jun 7, 2023
Co-authored-by: Dimitri Yatsenko <dimitri@datajoint.com>
Co-authored-by: Dimitri Yatsenko <dimitri@datajoint.com>
@dimitri-yatsenko dimitri-yatsenko self-requested a review June 7, 2023 20:22
@dimitri-yatsenko dimitri-yatsenko merged commit 2e33991 into datajoint:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove order requirements for test_pipeline_generation.py
6 participants