Skip to content

Conversation

kushalbakshi
Copy link
Collaborator

@kushalbakshi kushalbakshi commented May 14, 2023

This PR fixes an error when staging=False in the dandi upload utility. The existing code resulted in a URL that is just the dandiset_id rather than the full URL, resulting in an error.

PR Summary:

  • Fix DANDI upload URL
  • Test the fix locally
  • Update CHANGELOG
  • Update version.py

@kushalbakshi kushalbakshi requested a review from kabilar May 14, 2023 13:41
Copy link
Collaborator

@kabilar kabilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kushalbakshi!

@kabilar kabilar merged commit 51b9bdc into datajoint:main May 16, 2023
@kabilar
Copy link
Collaborator

kabilar commented May 25, 2023

Version 0.5.4 is tagged and released on GitHub, published to PyPI, and docs are deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants