-
-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New-DbaAvailabilityGroup: Add support for contained availability groups #9352
Merged
potatoqualitee
merged 15 commits into
dataplat:development
from
DorBreger:firenewcontainedags
May 16, 2024
Merged
New-DbaAvailabilityGroup: Add support for contained availability groups #9352
potatoqualitee
merged 15 commits into
dataplat:development
from
DorBreger:firenewcontainedags
May 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added an extra check for major version to be consistent with source
andreasjordan
changed the title
support for contained availability groups
New-DbaAvailabilityGroup: Add support for contained availability groups
May 15, 2024
Failed test is:
@potatoqualitee - please fix this before merging. |
andreasjordan
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
Please close #9345 if this PR is merged. |
10 tasks
Fantastic, all tests pass 🚀 Thanks to everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
.\tests\manual.pester.ps1
)Purpose
Support for sql server 2022 availability groups
Approach
Commands to test
Screenshots
Learning