Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New-DbaAvailabilityGroup: Add support for contained availability groups #9352

Merged
merged 15 commits into from
May 16, 2024

Conversation

DorBreger
Copy link
Contributor

@DorBreger DorBreger commented May 15, 2024

Type of Change

  • Bug fix (non-breaking change, fixes # )
  • New feature (non-breaking change, adds functionality, fixes Create contained availability group #8713 )
  • Breaking change (affects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

Purpose

Support for sql server 2022 availability groups

Approach

Commands to test

Screenshots

Learning

@andreasjordan andreasjordan changed the title support for contained availability groups New-DbaAvailabilityGroup: Add support for contained availability groups May 15, 2024
@andreasjordan
Copy link
Contributor

Failed test is:

Describe : dbatools style
Context  : BOM
Name     : It New-DbaAvailabilityGroup.ps1 has no BOM in it
Result   : Failed
Message  : Expected strings to be the same, but they were different.
           Expected length: 4
           Actual length:   7
           Strings differ at index 4.
           Expected: 'utf8'
           But was:  'utf8bom'
           ---------------^
Describe : dbatools style
Context  : formatting
Name     : It New-DbaAvailabilityGroup.ps1 is not compliant with the OTBS formatting style. Please run Invoke-DbatoolsFormatter against the failing file and commit the changes.
Result   : Failed
Message  : Expected 0, but got 1.

@potatoqualitee - please fix this before merging.

Copy link
Contributor

@andreasjordan andreasjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@andreasjordan
Copy link
Contributor

Please close #9345 if this PR is merged.

@potatoqualitee
Copy link
Member

Fantastic, all tests pass 🚀 Thanks to everyone!

@potatoqualitee potatoqualitee merged commit d485883 into dataplat:development May 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create contained availability group
4 participants