Support for writing blob values using a bytearray type (makes blobs work with Cassandra 2.0) #39
+133
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way the client also work with Cassandra 2.0.
tests/integration/test_types.py
Outdated
There was a problem hiding this comment.
Should this only map the first two parts? 3.0.X = 1.2, 3.1.X = 2.0?
There was a problem hiding this comment.
@JeremiahDJordan Yeah, I could do that.
I wonder I should use a different / better approach thought. I guess I could also just do SELECT cql_version, release_version FROM local in the System keyspace.
What do you think?
There was a problem hiding this comment.
@JeremiahDJordan I've changed it to use system.local column family in f1f329d.
I think this approach is a lot better and nicer than the other one.
Instead of using cql_version Cluster constructor argument query the "system.local" table.
This seems like a useful functionality so make it more easier to re-use this information.
|
I made some minor adjustments and merged it in to master. Thanks! |
|
Sweet, thanks :) |
aboudreault
added a commit
that referenced
this pull request
Jan 14, 2020
PYTHON-1192: Insights fail to serialize the startup message when the SSL Context is from PyOpenSSL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a solution described in #37.
This branch allows user to write a blob field value using a Python
bytearraytype. This is an only supported method for writing blobs when using Cassandra 2.0 and above.With older versions (1.2 and lower), user can use an existing approach (specifying a blob value using a hex encoded string) plus this approach.
Ideally, we would discourage "bad" practices (maybe by putting a note in the docs / readme) and advise users to use
bytearrayapproach which works with both versions.