This repository was archived by the owner on Jul 16, 2020. It is now read-only.
fix(indexes): Fix typo on suggested .indexOn rules #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow! Super fast @jsayol! Can you also change the comment for the function as well? |
|
Woops, missed it. |
|
Dammit, I'm editing the file directly from inside GitHub and the built-in editor insists on adding a newline character at the end of the file. Fixed it, I don't like half-assing things. |
|
I removed the extra newline and squashed it all in one single commit. Sorry for all the noise! |
The message suggest to add an `._indexOn` rule but that should actually say `.indexOn`. Additionally, make it clear that no action needs to be taken if the rules have already been added.
|
Thank you so much @jsayol! |
|
Just realized I missed a typo on my own commit message. Oh well. |
davideast
pushed a commit
that referenced
this pull request
Nov 28, 2016
The message suggest to add an `._indexOn` rule but that should actually say `.indexOn`. Additionally, make it clear that no action needs to be taken if the rules have already been added.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message suggests to add an
._indexOnrule but that should actually say.indexOn. Additionally, make it clear that no action needs to be taken if the rules have already been added.