Skip to content

fix: incorrectly not inheriting values within details elements #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 4, 2023
Merged

fix: incorrectly not inheriting values within details elements #495

merged 4 commits into from
Jul 4, 2023

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Jul 2, 2023 •
edited
Loading

Resolves #494

Introducing a CSS variable to still be able to overwrite the box-sizing value (which is the spirit of this whole thing), instead of e.g. "redeclaring" the following:

details {
	& > *,
	& > ::before,
	& > ::after {
		box-sizing: border-box;
	}
}

but doing the following instead:

https://github.com/db-ui/core/pull/495/files#diff-3c4b77e29eed06d8c4323c5b88e5e8bd3c78b0c2e077cda82f83eef04836614fR69-R77

more information on the problem:
https://kittygiraudel.com/2021/08/23/shadow-roots-and-inheritance/ & https://stackoverflow.com/questions/75347448/box-sizing-not-inherited-through-details-element

See also https://github.com/db-ui/mono/pull/1205

@mfranzke mfranzke added the bug Something isn't working label Jul 2, 2023
@mfranzke mfranzke added this to the Release 2.x milestone Jul 2, 2023
@mfranzke mfranzke requested a review from nmerget as a code owner July 2, 2023 14:52
@mfranzke mfranzke self-assigned this Jul 2, 2023
@mfranzke mfranzke requested review from dkolba and annsch as code owners July 2, 2023 14:52
@mfranzke mfranzke linked an issue Jul 2, 2023 that may be closed by this pull request
Buttons in accordion inherit wrong box-sizing #494
Closed
@mfranzke mfranzke changed the title fix: incorrectly not inheriting values within details elements #494 fix: incorrectly not inheriting values within details elements #494 Jul 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

🔭🐙🐈 Test this branch here: https://db-ui.github.io/core/review/494-buttons-in-accordion-inherit-wrong-box-sizing

@mfranzke mfranzke enabled auto-merge (squash) July 2, 2023 14:52
@mfranzke mfranzke changed the title fix: incorrectly not inheriting values within details elements #494 fix: incorrectly not inheriting values within details elements Jul 2, 2023
nmerget
nmerget reviewed Jul 3, 2023
View reviewed changes
@mfranzke mfranzke requested a review from nmerget July 4, 2023 08:35
@mfranzke mfranzke mentioned this pull request Jul 4, 2023
Merged
@mfranzke mfranzke merged commit f3b0166 into main Jul 4, 2023
@mfranzke mfranzke deleted the 494-buttons-in-accordion-inherit-wrong-box-sizing branch July 4, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget nmerget approved these changes

@dkolba dkolba Awaiting requested review from dkolba dkolba is a code owner

@annsch annsch Awaiting requested review from annsch annsch is a code owner

Assignees

@mfranzke mfranzke

Labels
bug Something isn't working patterns
Projects
None yet
Milestone
Guidelines v2
Development

Successfully merging this pull request may close these issues.

Buttons in accordion inherit wrong box-sizing
2 participants
@mfranzke @nmerget