Skip to content

fix: incorrectly not inheriting values within details elements #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 4, 2023
Merged

fix: incorrectly not inheriting values within details elements #495

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ccf5ed3
fix: incorrectly not inheriting values within details elements #494
mfranzke Jul 2, 2023
9ac5204
refactor: hardening this
mfranzke Jul 2, 2023
da89ebb
docs: further adjusted that comment
mfranzke Jul 2, 2023
97557d2
Merge branch 'main' into 494-buttons-in-accordion-inherit-wrong-box-s…
mfranzke Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion source/_patterns/00-base/_init.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Box sizing
html {
box-sizing: border-box;
box-sizing: var(--db-box-sizing, border-box);
}

*,
Expand Down Expand Up @@ -66,3 +66,12 @@ nav,
color: $db-color-red-500;
}
}

// details/summary box-sizing / https://kittygiraudel.com/2021/08/23/shadow-roots-and-inheritance/
details {
& > *,
& > ::before,
& > ::after {
box-sizing: var(--db-box-sizing, border-box);
}
}