Skip to content

fix(accordion): replaced height by paddings #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 11, 2022
Merged

fix(accordion): replaced height by paddings #80

merged 4 commits into from
Oct 11, 2022

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Oct 10, 2022 •
edited
Loading

Closes #77

@mfranzke mfranzke added the bug Something isn't working label Oct 10, 2022
@mfranzke mfranzke added this to the Release 2.0 milestone Oct 10, 2022
@mfranzke mfranzke requested a review from nmerget as a code owner October 10, 2022 18:23
@mfranzke mfranzke self-assigned this Oct 10, 2022
@mfranzke mfranzke linked an issue Oct 10, 2022 that may be closed by this pull request
BUG: db-accordion Summary is not sizing well when text is too long #77
Closed
@mfranzke mfranzke enabled auto-merge (squash) October 10, 2022 18:24
annsch
annsch approved these changes Oct 11, 2022
View reviewed changes
Copy link
Collaborator

@annsch annsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked with long summary text and works as expected 👌

@mfranzke mfranzke merged commit fa49860 into main Oct 11, 2022
@mfranzke mfranzke deleted the 77-bug-db-accordion-summary-is-not-sizing-well-when-text-is-too-long branch October 11, 2022 07:28
@mfranzke mfranzke added the legacy relevant something we should adapt to our earlier inner source version label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget nmerget left review comments

@annsch annsch annsch approved these changes

@dkolba dkolba Awaiting requested review from dkolba dkolba is a code owner

Assignees

@mfranzke mfranzke

Labels
bug Something isn't working legacy relevant something we should adapt to our earlier inner source version patterns
Projects
None yet
Milestone
Guidelines v2
Development

Successfully merging this pull request may close these issues.

BUG: db-accordion Summary is not sizing well when text is too long
3 participants
@mfranzke @annsch @nmerget