Skip to content

fix(accordion): replaced height by paddings #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 11, 2022
Merged

fix(accordion): replaced height by paddings #80

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
29eed02
fix(accordion): replaced height by paddings
mfranzke Oct 10, 2022
83010a5
Merge branch 'main' into 77-bug-db-accordion-summary-is-not-sizing-we…
mfranzke Oct 11, 2022
eca21d2
Merge branch 'main' into 77-bug-db-accordion-summary-is-not-sizing-we…
mfranzke Oct 11, 2022
0176d26
Merge branch 'main' into 77-bug-db-accordion-summary-is-not-sizing-we…
mfranzke Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions source/_patterns/02-components/accordion/accordion.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
summary {
@include icon(glyph(chevron-right), 24, "outline", $partial: $partial);

height: to-rem($pxValue: 48);
padding-block: $db-spacing-sm;
display: flex;
align-items: center;
// Negating the padding left for moving the element into that direction with the same measures
Expand Down Expand Up @@ -74,7 +74,8 @@
)};

summary {
height: to-rem($pxValue: 40);
// ToDo: This needs to get replaced by the correct variable
padding-block: 0.59375rem;
font-size: to-rem($pxValue: 14);

&::before {
Expand All @@ -91,7 +92,7 @@
)};

summary {
height: to-rem($pxValue: 64);
padding-block: $db-spacing-m;
font-size: to-rem($pxValue: 20);

&::before {
Expand Down