Skip to content

feat: add github logo in storybook #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 25, 2022
Merged

feat: add github logo in storybook #5

merged 5 commits into from
Jul 25, 2022

Conversation

@nmerget
Copy link
Member

@nmerget nmerget commented Jul 20, 2022

No description provided.

@nmerget nmerget requested review from dkolba and mfranzke as code owners July 20, 2022 15:41
mfranzke
mfranzke requested changes Jul 20, 2022
View reviewed changes
Copy link
Member

@mfranzke mfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmerget please add a packages/db-ui-elements-stencil/src/assets/GitHub-Mark-Light-32px.png.license file that includes the license information for this image.

@nmerget
Copy link
Member Author

nmerget commented Jul 25, 2022

@nmerget please add a packages/db-ui-elements-stencil/src/assets/GitHub-Mark-Light-32px.png.license file that includes the license information for this image.

fixed

@nmerget nmerget closed this Jul 25, 2022
@nmerget nmerget reopened this Jul 25, 2022
@nmerget nmerget requested a review from mfranzke July 25, 2022 07:04
dkolba
dkolba approved these changes Jul 25, 2022
View reviewed changes
Copy link
Collaborator

@dkolba dkolba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmerget
nmerget commented Jul 25, 2022
View reviewed changes
Copy link
Member Author

@nmerget nmerget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@nmerget nmerget merged commit 8b3423e into main Jul 25, 2022
@nmerget nmerget deleted the feat-github-link-for-pages branch July 25, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkolba dkolba dkolba approved these changes

@mfranzke mfranzke mfranzke approved these changes

Assignees

No one assigned

Labels

stencil

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nmerget @dkolba @mfranzke