Add element type property to LinkableElement interface #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2024
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
|
Need to make another update and it makes sense to put it in here. |
courtneyholcomb
approved these changes
May 23, 2024
| @property | ||
| @abstractmethod | ||
| def element_type(self) -> LinkableElementType: | ||
| """Blah.""" |
tlento
force-pushed
the
encapsulate-time-range-constraint-addition
branch
from
42aadf8
to
c9fd6dd
Compare
tlento
force-pushed
the
add-element-type-to-linkable-element-interface
branch
from
9040f9f
to
ee88ff9
Compare
tlento
force-pushed
the
encapsulate-time-range-constraint-addition
branch
from
c9fd6dd
to
e817118
Compare
Base automatically changed from
encapsulate-time-range-constraint-addition
to
main
May 24, 2024 01:03
The LinkableElement interface is used in cases where we have a set of LinkableElements undifferentiated by underlying type. In predicate pushdown, this happens with where specs that reference some set of linkable elements but store them in an undifferentiated collection. In practice, we need to know not just the object type, but the more refined LinkableElementType in order to apply the pushdown evaluation logic, as time dimensions and categorical dimensions need to be considered in a distinct way. This makes the relevant property available in the parent interface so we can access it directly.
tlento
force-pushed
the
add-element-type-to-linkable-element-interface
branch
from
ee88ff9
to
2ec263f
Compare
This was referenced Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LinkableElement interface is used in cases where we have a
set of LinkableElements undifferentiated by underlying type.
In predicate pushdown, this happens with where specs that reference
some set of linkable elements but store them in an undifferentiated
collection.
In practice, we need to know not just the object type, but the more
refined LinkableElementType in order to apply the pushdown evaluation
logic, as time dimensions and categorical dimensions need to be
considered in a distinct way.
This makes the relevant property available in the parent interface
so we can access it directly.