-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encapsulate time range constraint application in more general method #1225
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
1 similar comment
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
dad601d
to
7882c02
Compare
42aadf8
to
c9fd6dd
Compare
7882c02
to
508cfb9
Compare
The time range constraint is our currently supported predicate pushdown operation. The specific application of a time range constraint is inlined in the DataflowPlanBuilder. This moves it to a more general function, which will make it easier for us to handle other predicate pushdown states while keeping the conditional logic contained. Note this is effectively a no-op as the new function is currently a pass-through. This is borne out by the lack of changes in our snapshots, several of which cover the time range node.
c9fd6dd
to
e817118
Compare
The time range constraint is our currently supported predicate pushdown
operation. The specific application of a time range constraint is
inlined in the DataflowPlanBuilder. This moves it to a more general
function, which will make it easier for us to handle other predicate
pushdown states while keeping the conditional logic contained.
Note this is effectively a no-op as the new function is currently a
pass-through. This is borne out by the lack of changes in our snapshots,
several of which cover the time range node.