Encapsulate time range constraint application in more general method #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2024
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
1 similar comment
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
tlento
force-pushed
the
rename-predicate-pushdown-params
branch
from
dad601d
to
7882c02
Compare
tlento
force-pushed
the
encapsulate-time-range-constraint-addition
branch
from
42aadf8
to
c9fd6dd
Compare
tlento
force-pushed
the
rename-predicate-pushdown-params
branch
from
7882c02
to
508cfb9
Compare
The time range constraint is our currently supported predicate pushdown operation. The specific application of a time range constraint is inlined in the DataflowPlanBuilder. This moves it to a more general function, which will make it easier for us to handle other predicate pushdown states while keeping the conditional logic contained. Note this is effectively a no-op as the new function is currently a pass-through. This is borne out by the lack of changes in our snapshots, several of which cover the time range node.
tlento
force-pushed
the
encapsulate-time-range-constraint-addition
branch
from
c9fd6dd
to
e817118
Compare
This was referenced Jun 12, 2024
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time range constraint is our currently supported predicate pushdown
operation. The specific application of a time range constraint is
inlined in the DataflowPlanBuilder. This moves it to a more general
function, which will make it easier for us to handle other predicate
pushdown states while keeping the conditional logic contained.
Note this is effectively a no-op as the new function is currently a
pass-through. This is borne out by the lack of changes in our snapshots,
several of which cover the time range node.