Move node dataset resolver subquery ids into a separate namespace

[tlento]

Move node dataset resolver subquery ids into a separate namespace

The DataflowPlanNodeOutputDataSetResolver class extends the
DataflowToSqlQueryPlanConverter class. As a result, both classes
effectively do a full conversion from a DataflowPlan to a SqlQueryPlan,
complete with SqlQueryPlan node_id generation. These shared the
same ID prefix, which meant any call that might trigger an additional
invocation of the node dataset resolver subclass could cause shifts
in the subquery IDs in our SqlQueryPlan outputs even if the invocation
had no material impact on the query in question.

In order to reduce snapshot thrash and make our subquery IDs easier to
reason about on read-through of the generated SQL, this change splits
the node dataset resolver ID prefix into a dedicated value.

Update engine snapshots

[tlento]

• Enable PredicatePushdownOptimization for all MetricFlowEngine queries #1308
• Enforce order of application for DataflowPlanOptimizers #1307
• Enable SourceScanOptimizer in query rendering tests #1306
• Add SQL rendering tests for pushdown edge cases #1305
• Remove duplicated WhereConstraintNodes in predicate pushdown #1304
• Add direct tests for predicate pushdown optimizer #1303
• Track and propagate applied where filter specs to outer plan nodes #1302
• Simplify predicate pushdown state tracking #1301
• Consolidate where constraint predicate pushdown management #1300
• Move categorical dimension filter pushdown to PredicatePushdownOptimizer #1286
• Move node dataset resolver subquery ids into a separate namespace #1280 👈
• Verify column sets match in optimizer pushdown evaluation #1279
• Update API for requesting dataflow plan optimization #1278
• Store a list of input WhereFilterSpecs in the WhereConstraintNode #1277
• Enable DataflowPlanOptimizers for query rendering tests #1263
• Add PredicatePushdownOptimizer in tracking-only mode #1262
• Add integration tests for filters against various join types #1240
• Enable predicate pushdown for categorical dimension filters #1227
• Add semantic_model_origin property to LinkableElement interface #1230
• Add element type property to LinkableElement interface #1226
• Encapsulate time range constraint application in more general method #1225
• Rename PredicatePushdownParameters to PredicatePushdownState #1224
• Make source_semantic_models property accessible from a DataflowPlanNode #1218
• Use pushdown params to disable time range constraint pushdown #1216 : 1 other dependent PR (#1217 )
• Encapsulate time range constraints for predicate pushdown #1215
• Add conversion metric rendering tests #1214
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tlento and the rest of your teammates on Graphite

[github-actions]

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

[courtneyholcomb]

Helpful thank you!

[tlento]

Merge activity

• Jun 24, 8:29 PM PDT: @tlento started a stack merge that includes this pull request via Graphite.
• Jun 24, 9:02 PM PDT: Graphite rebased this pull request as part of a merge.
• Jun 24, 9:06 PM PDT: @tlento merged this pull request with Graphite.