Verify column sets match in optimizer pushdown evaluation #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 14, 2024
This was referenced Jun 14, 2024
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
tlento
force-pushed
the
update-dataflow-optimizer-call-mechanism
branch
from
5a904ed
to
ae3d6ff
Compare
tlento
force-pushed
the
evaluate-columns-for-pushdown
branch
from
fda9d9b
to
cd70c5d
Compare
This was referenced Jun 25, 2024
tlento
force-pushed
the
update-dataflow-optimizer-call-mechanism
branch
from
ae3d6ff
to
8d4d7fd
Compare
Base automatically changed from
update-dataflow-optimizer-call-mechanism
to
main
June 25, 2024 03:56
The PredicatePushdownOptimizer did not have access to the node dataset resolver necessary to do the comparison between the linkable specs referenced in the where filter and the linkable specs available from the DataflowPlanNode targeted by predicate pushdown. This change makes the node dataset resolver available in the optimizer. It uses the one from the DataflowPlanBuilder in order to take advantage of the cached resolutions available from the build process. The optimizer is then used to evaluate the column matches in the same manner as the original build-time pushdown evaluation. This change was tested by running one of the predicate pushdown rendering tests with the --log-cli-level=DEBUG confugration set, and observing the debug output including the same entry for "Filter specs to add:" as in the preceding commit.
tlento
force-pushed
the
evaluate-columns-for-pushdown
branch
from
cd70c5d
to
6b94906
Compare
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PredicatePushdownOptimizer did not have access to the node
dataset resolver necessary to do the comparison between the linkable
specs referenced in the where filter and the linkable specs available
from the DataflowPlanNode targeted by predicate pushdown.
This change makes the node dataset resolver available in the optimizer.
It uses the one from the DataflowPlanBuilder in order to take advantage
of the cached resolutions available from the build process. The optimizer
is then used to evaluate the column matches in the same manner as the
original build-time pushdown evaluation.
This change was tested by running one of the predicate pushdown rendering
tests with the --log-cli-level=DEBUG confugration set, and observing the
debug output including the same entry for "Filter specs to add:" as in
the preceding commit.