Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PredicatePushdownParameters to PredicatePushdownState #1224

Merged
merged 3 commits into from
May 24, 2024

Conversation

tlento
Copy link
Contributor

@tlento tlento commented May 22, 2024

Rename PredicatePushdownParameters to PredicatePushdownState

The PredicatePushdownParameters class is really a state tracking
container to help us determine whether and how to do predicate pushdown,
o we update the name to match its function.

Update pushdown_params -> pushdown_state

Straggling renames plus documentation updates

Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link
Contributor

@courtneyholcomb courtneyholcomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable!

@tlento tlento force-pushed the make-source-semantic-models-available-from-nodes branch from 9ef3244 to 45cf01f Compare May 23, 2024 23:41
@tlento tlento force-pushed the rename-predicate-pushdown-params branch from dad601d to 7882c02 Compare May 23, 2024 23:41
Copy link
Contributor Author

tlento commented May 24, 2024

Merge activity

  • May 23, 5:33 PM PDT: @tlento started a stack merge that includes this pull request via Graphite.
  • May 23, 5:53 PM PDT: Graphite rebased this pull request as part of a merge.
  • May 23, 5:57 PM PDT: @tlento merged this pull request with Graphite.

@tlento tlento force-pushed the make-source-semantic-models-available-from-nodes branch from 45cf01f to f0c6cb9 Compare May 24, 2024 00:47
Base automatically changed from make-source-semantic-models-available-from-nodes to main May 24, 2024 00:52
The PredicatePushdownParameters class is really a state tracking
container to help us determine whether and how to do predicate pushdown,
o we update the name to match its function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants