Build #25

texastoland · 2015-08-03T22:03:44Z

This is the big one. I'll just list features:

Two standard build commands triggered with Super+[Shift]+B or Super+[Shift]+F7.
- The first just check errors. Credit to @rtfeldman's tweet!
- Run additionally builds output to an intelligent path.
Errors are formatted for small space. They're navigable with Super+[Shift]+F4. Error highlighting is integrated with Highlight Build Errors (ST3 only) plugin if installed.
Compile messages are both highlighted and colored including embedded source 🎨
Ouput paths are configurable in elm-package.json. Keys not documented? No fear! There's a UI labeled Elm Build System in the Command Palette. It only requires a valid config in any ancestor directory of the edited file.
Launch generated HTML in your browser from an Elm source file. It requires SideBarEnhancements (ST3 only) if installed or alternatively View In Browser plugin. Not building HTML? That path is configurable in the Command Palete too.
Fully ST2/ST3 compatible.

Intercept and reformat compiler errors by subclassing ExecCommand

Proxy to external plugin if installed otherwise inform user

Mirror sublime.expand_variables syntax. But sublime functions would make code less clear here. Revisit for ST2 compatibility

Read and write build settings with intelligent defaults

Enable custom builds instead of compiling without output. Fix empty compile on Windows

rtfeldman · 2015-08-04T03:55:27Z

Tried it out, got this in the console:

Some new packages are needed. Here is the upgrade plan.

  Install:
    elm-lang/core 2.1.0

Do you approve of this plan? (y/n) elm-make: <stdin>: hGetLine: end of file
[Finished in 1.0s with exit code 1]
[shell_cmd: elm-make]
[dir: /Users/rtfeldman/code/elm-core/src]
[path: /usr/bin:/bin:/usr/sbin:/sbin]

I've seen the hGetLine: end of file error before (it's a Haskell thing), and we've worked around it by setting the LANG env var. I tried doing that in the build config...

{
  "env": {
    "LANG": "en_US.UTF-8"
  },
  "shell_cmd": "elm-make"
}

...but this time it didn't help.

Anyway, the error was happening because the file I was editing (Maybe.elm in core) happened to be in the src/ directory instead of the project root. elm-make needs to run in whatever directory elm-package.json lives in, so I hacked around it by doing this:

{
  "working_dir": "../",
  "shell_cmd": "elm-make"
}

...although naturally that's not a scalable solution. 😄

rtfeldman · 2015-08-04T03:58:56Z

At that point the build ran and I saw the output in the console, which was pretty sweet!

I have Highlight Build Errors installed, but didn't see any inline. (I also tried uninstalling/reinstalling Highlight Build Errors, uninstalling/reinstalling elm-sublime, and restarting Sublime Text 3, but still no highlighting.)

Awesome progress @dnalot! 😃

rtfeldman · 2015-08-04T04:05:10Z

Same deal with SublimeREPL: I have it installed, but don't see Elm integrations.

rtfeldman · 2015-08-04T04:08:16Z

Also, for reference, this is the version I had installed:

texastoland · 2015-08-04T04:08:50Z

Mind reporting each in my fork?

Re. src folder: Looking now!
Re. Highlighting: do F4/Shift+F4 select your errors in the build panel?
Re. REPL: do you see anything Elm or REPL related in the Console (Ctrl+`), especially at startup?

texastoland · 2015-08-04T05:43:32Z

Status:

I couldn't repro the hGetLine issue. I'm supposed to be passing the --yes flag? I meant to account for it if you can raise the issue.
Looks like an issue with elm-make prepending JSON with a message. I have a solution for that. Reported upstream --report=json doesn't return JSON elm-lang/elm-make#38. Issue in mine wouldn't hurt.
Thanks for making dnalot/elm-sublime#1. I think it's an initialization order thing. I'd seen it intermittently but your log clarified it.

Integrate SideBarEnhancements for ST3 for poplarity and browser detection

Also appears in Tools menu

Load external dependencies lazily. Flip of the coin whether they error otherwise

Fix import for execCommand. Lazily load Highlight Build Errors c.f. previous commit

Parse plain string lines interspersed with JSON from elm-make

deadfoxygrandpa · 2015-08-06T04:32:29Z

I just remembered this, and so I don't forget it I'll write it down. the --output /dev/null trick doesn't work on Windows, but I just tried --output NUL and that seems to work, so we should probably do it that way on Windows.

texastoland · 2015-08-06T04:38:55Z

I already did it. Don't merge yet though! I just rebased.

Remember kids, don't try this at home

texastoland · 2015-08-06T07:06:23Z

@rtfeldman All issues should be fixed 🙏

...because I over-engineered it

vilterp · 2015-08-06T19:05:15Z

Is it possible to hyperlink from errors in the console to the code?

rtfeldman · 2015-08-06T19:31:17Z

That would be very nice, if possible!

On Thu, Aug 6, 2015, 12:05 PM Pete Vilter notifications@github.com wrote:

Is it possible to hyperlink from errors in the console to the code?

—
Reply to this email directly or view it on GitHub
#25 (comment)
.

texastoland · 2015-08-06T19:45:44Z

Yes but I'm still evaluating how to do it with the least amount of code. Basically it's completely custom navigation. Report it in either repo and I'll tag it as a feature!

vilterp · 2015-08-06T21:04:30Z

Reported in your fork (issue 3)

- Conventional property naming - Fix ST2/3 incompatibility - Log decoded elm-package.json

Also simplify common imports

Because this took hours to diagnose myself

Maintain key order in elm-package.json for diffs and log JSON key paths

Beware: MRO currently broken for patched methods

Build system file_regex only navigate single lines. In the future we could provide an enhanced double click handler

texastoland · 2015-08-14T01:29:53Z

@deadfoxygrandpa This one's ready to merge. I'll open a separate PR for a ST3 error in existing code. Also looking into #28 if you can take #29?

Build

deadfoxygrandpa · 2015-08-14T15:12:02Z

OK, I'll merge it in. Thanks a lot for all this work.

texastoland added 10 commits August 2, 2015 19:48

Initial build system

c8f77f1

Implement error matching in output panel

7bd9e13

Intercept and reformat compiler errors by subclassing ExecCommand

Integrate Highlight Build Errors

e0c05f5

Proxy to external plugin if installed otherwise inform user

Switch from string.format to Template.substitute

6cf3d3b

Mirror sublime.expand_variables syntax. But sublime functions would make code less clear here. Revisit for ST2 compatibility

Add command for manipulating elm-package.json

7f01bb3

Read and write build settings with intelligent defaults

Intercept make command with new ElmProject

5302ced

Enable custom builds instead of compiling without output. Fix empty compile on Windows

Gracefully recover from parse errors

8ec684c

Fix ST2 compatibility

d40eaa2

Disable project commands when missing config

9f5e93e

Fix dirname error on None

20bf16b

texastoland added 8 commits August 5, 2015 13:21

Localize user strings

3428bc0

Initial open in browser command

815e9d7

Add alternative support for open in browser

2b70b4d

Integrate SideBarEnhancements for ST3 for poplarity and browser detection

Rename build system

70836af

Also appears in Tools menu

Rewrite open in browser

a00b1e7

Load external dependencies lazily. Flip of the coin whether they error otherwise

Refactor build command

729525c

Fix import for execCommand. Lazily load Highlight Build Errors c.f. previous commit

Fix error parsing

568c398

Parse plain string lines interspersed with JSON from elm-make

Improve logging

b81611d

texastoland added 2 commits August 5, 2015 23:42

Highlight build output ✨

ccdabf5

Remember kids, don't try this at home

Also pass custom color scheme

2b1accf

Simplify passing syntax to build

3ae8fe3

...because I over-engineered it

texastoland added 11 commits August 7, 2015 23:14

Overhaul logging

68121f9

- Conventional property naming - Fix ST2/3 incompatibility - Log decoded elm-package.json

Buffer compile results to fix dnalot/sublime-language-elm#5

be5e31e

Refactor ElmProjectCommand and rename lazy imports

53d77c0

Specify exception handling

9b82a62

Refactor logging into togglable module

63f36c4

Also simplify common imports

Add status message when HTML not found to open

b211f1b

Because this took hours to diagnose myself

Fix dnalot/sublime-language-elm#2

8b5c506

Maintain key order in elm-package.json for diffs and log JSON key paths

Factor out monkey patching

b6bde69

Refactor lazy imports into decorator

0efa6af

Beware: MRO currently broken for patched methods

Fix broken MRO and improve decorator naming

b7834b7

Fix dnalot/sublime-language-elm#3

1f26d82

Build system file_regex only navigate single lines. In the future we could provide an enhanced double click handler

deadfoxygrandpa added a commit that referenced this pull request Aug 14, 2015

Merge pull request #25 from dnalot/build

2f325f3

Build

deadfoxygrandpa merged commit 2f325f3 into deadfoxygrandpa:develop Aug 14, 2015

texastoland deleted the build branch August 17, 2015 17:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build #25

Build #25

texastoland commented Aug 3, 2015

rtfeldman commented Aug 4, 2015

rtfeldman commented Aug 4, 2015

rtfeldman commented Aug 4, 2015

rtfeldman commented Aug 4, 2015

texastoland commented Aug 4, 2015

texastoland commented Aug 4, 2015

deadfoxygrandpa commented Aug 6, 2015

texastoland commented Aug 6, 2015

texastoland commented Aug 6, 2015

vilterp commented Aug 6, 2015

rtfeldman commented Aug 6, 2015

texastoland commented Aug 6, 2015

vilterp commented Aug 6, 2015

texastoland commented Aug 14, 2015

deadfoxygrandpa commented Aug 14, 2015

Build #25

Build #25

Conversation

texastoland commented Aug 3, 2015

rtfeldman commented Aug 4, 2015

rtfeldman commented Aug 4, 2015

rtfeldman commented Aug 4, 2015

rtfeldman commented Aug 4, 2015

texastoland commented Aug 4, 2015

texastoland commented Aug 4, 2015

deadfoxygrandpa commented Aug 6, 2015

texastoland commented Aug 6, 2015

texastoland commented Aug 6, 2015

vilterp commented Aug 6, 2015

rtfeldman commented Aug 6, 2015

texastoland commented Aug 6, 2015

vilterp commented Aug 6, 2015

texastoland commented Aug 14, 2015

deadfoxygrandpa commented Aug 14, 2015