-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor CI pipelines #11196
Refactor CI pipelines #11196
Conversation
9d62a35
to
d9b4e5e
Compare
d9b4e5e
to
1fc8d17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have some suggestions with the duplication in the generators spec runtimes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just what I had in mind, great job!
Ignoring the failing spec as that's already fixed on |
* Refactor CI pipelines * DRY generator specs * Removed duplicate code * Fix failing specs
* develop: (30 commits) Add `process-content` to erb-lint's deprecated classes (#11762) Add possibility of overriding the tailwind.config.js (#11763) Ask old password when changing email or password (#11737) Add Projects (Budgets) to filtered search (#11740) Fix missing results on Geocoded when search without diacritics (#11761) Add robots.txt instructions (#11693) Add missing activerecord budget locales for search (#11766) Improve design of Admin's Sidebar pages (#11759) Show small static map on admin's meetings index with big screens (#11715) Remove "Manage" button when there's a Sidebar (#11717) Fix admin breadcrumb in Process (#11757) Apply new rubocop rules on erb - Layout/MultilineMethodCallIndentation (#11756) Remove xlarge-* references from admin forms (#11712) Apply new rubocop rules on erb - Argument identation (#11707) Update HERE API autocomplete (#11507) Admin redesign proposal issues (#11668) Redesign: responsive links on cards (#11538) Refactor CI pipelines (#11196) Update postcss and graphql to latest versions (#11733) Fix develop pipeline (#11750) ...
🎩 What? Why?
This PR improves the name of several github Workflows.
It also aims to reduce the amount of time spent by generators specs.
It also splits the linting Pipeline into independent flows so that we could obtain a faster input when we have multiple linting offenses.
Testing
📷 Screenshots
Brakeman:
![image](https://private-user-images.githubusercontent.com/105683/274158657-0055be01-f9b4-438f-a096-f211446a1410.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1NTIzNjgsIm5iZiI6MTcyMDU1MjA2OCwicGF0aCI6Ii8xMDU2ODMvMjc0MTU4NjU3LTAwNTViZTAxLWY5YjQtNDM4Zi1hMDk2LWYyMTE0NDZhMTQxMC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzA5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwOVQxOTA3NDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02NDQ3MTQ5MzViM2RiZmY2MzVjMDQ5NGZkODljZWVlM2Q0MzAyMTk3MTlhMGIyMDU1ZDgzNGZmN2VmODhkZGFiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.FOo5hM7ZsKdq5NgLS5295hzNMfLDJynRiehbYOvll9o)
Before:
After:
![image](https://private-user-images.githubusercontent.com/105683/274158576-58838781-9f59-4ab6-9e83-b2bd22d8171b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1NTIzNjgsIm5iZiI6MTcyMDU1MjA2OCwicGF0aCI6Ii8xMDU2ODMvMjc0MTU4NTc2LTU4ODM4NzgxLTlmNTktNGFiNi05ZTgzLWIyYmQyMmQ4MTcxYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzA5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwOVQxOTA3NDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lNjExMDBhMzZiZjA0ZjVlMjkxNWMyNmFkMjYzNjg5NTJmOTE2M2ExY2VjMTAyNzk1ODI1OWVmNjgwODMzZGFmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.fiQHDCx_XEQdQ739mSFqrcReFMq2IL4SXCw7HsFs_gI)
Generators:
![image](https://private-user-images.githubusercontent.com/105683/274158797-8b3fbb0b-c3fd-4bfd-9b40-108fc8237efb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1NTIzNjgsIm5iZiI6MTcyMDU1MjA2OCwicGF0aCI6Ii8xMDU2ODMvMjc0MTU4Nzk3LThiM2ZiYjBiLWMzZmQtNGJmZC05YjQwLTEwOGZjODIzN2VmYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzA5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwOVQxOTA3NDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mMzEyYTQ3YmU4YTgwYzZiZmVhM2U5YjQ5MDAyZjA1ZjkxMzc1MzYwNmUxZjM3MDgwZTBhMzY2Njg1YTkyZjBkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.MfW034sWCgIwlQoFkIhLsapc9RqnMsoJuwyDH6XQNUI)
Before
After:
![image](https://private-user-images.githubusercontent.com/105683/274158875-a16e440c-392f-41a1-9a8b-b4b37688859c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1NTIzNjgsIm5iZiI6MTcyMDU1MjA2OCwicGF0aCI6Ii8xMDU2ODMvMjc0MTU4ODc1LWExNmU0NDBjLTM5MmYtNDFhMS05YThiLWI0YjM3Njg4ODU5Yy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzA5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwOVQxOTA3NDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01MjcyZTZkMjE0MjlhMTk5ZDY0NmM5OWM5MmU2MjIzMzM5MzU1YzczMGRhOWJjYjc0OWJjNzZhMWI4ZTEwZTYzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.BnuDVumtlCCKT4vHNHJZ8ka1Igq-K6xHx0V0e3yDDXM)