Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CI pipelines #11196

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Refactor CI pipelines #11196

merged 5 commits into from
Oct 13, 2023

Conversation

alecslupu
Copy link
Contributor

@alecslupu alecslupu commented Jul 16, 2023

🎩 What? Why?

This PR improves the name of several github Workflows.
It also aims to reduce the amount of time spent by generators specs.
It also splits the linting Pipeline into independent flows so that we could obtain a faster input when we have multiple linting offenses.

Testing

  1. Make sure the pipelines are green
  2. Check the time spent on generators
  3. Check the linter pipelines
  4. Check the names of Proposals, Meetings, Dev, Core pipelines

📷 Screenshots

Brakeman:
Before:
image

After:
image

Generators:
Before
image

After:
image

♥️ Thank you!

@alecslupu alecslupu force-pushed the chore/fix-pipelines branch 14 times, most recently from 9d62a35 to d9b4e5e Compare July 16, 2023 12:52
@alecslupu alecslupu changed the title Split even more the actions Refactor CI pipelines Oct 10, 2023
@alecslupu alecslupu added the type: internal PRs that aren't necessary to add to the CHANGELOG for implementers label Oct 10, 2023
@alecslupu alecslupu marked this pull request as ready for review October 11, 2023 06:01
@alecslupu alecslupu requested a review from a team October 11, 2023 06:01
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have some suggestions with the duplication in the generators spec runtimes.

decidim-generators/spec/runtime/queue_flag_spec.rb Outdated Show resolved Hide resolved
decidim-generators/spec/runtime/queue_flag_spec.rb Outdated Show resolved Hide resolved
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just what I had in mind, great job!

@andreslucena
Copy link
Member

Ignoring the failing spec as that's already fixed on develop with #11750

@andreslucena andreslucena merged commit 3c38a46 into develop Oct 13, 2023
102 of 104 checks passed
@andreslucena andreslucena deleted the chore/fix-pipelines branch October 13, 2023 12:47
andreslucena pushed a commit that referenced this pull request Oct 16, 2023
* Refactor CI pipelines

* DRY generator specs

* Removed duplicate code

* Fix failing specs
entantoencuanto added a commit that referenced this pull request Oct 17, 2023
* develop: (30 commits)
  Add `process-content` to erb-lint's deprecated classes (#11762)
  Add possibility of overriding the tailwind.config.js (#11763)
  Ask old password when changing email or password (#11737)
  Add Projects (Budgets) to filtered search (#11740)
  Fix missing results on Geocoded when search without diacritics (#11761)
  Add robots.txt instructions (#11693)
  Add missing activerecord budget locales for search (#11766)
  Improve design of Admin's Sidebar pages (#11759)
  Show small static map on admin's meetings index with big screens  (#11715)
  Remove "Manage" button when there's a Sidebar (#11717)
  Fix admin breadcrumb in Process (#11757)
  Apply new rubocop rules on erb - Layout/MultilineMethodCallIndentation (#11756)
  Remove xlarge-* references from admin forms (#11712)
  Apply new rubocop rules on erb - Argument identation (#11707)
  Update HERE API autocomplete (#11507)
  Admin redesign proposal issues (#11668)
  Redesign: responsive links on cards (#11538)
  Refactor CI pipelines (#11196)
  Update postcss and graphql to latest versions (#11733)
  Fix develop pipeline (#11750)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: internal PRs that aren't necessary to add to the CHANGELOG for implementers
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants