-
-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add robots.txt instructions #11693
Add robots.txt instructions #11693
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is already done in develop
with #10120, what I had in mind is to do this directly in v0.27 (release/0.27-stable
base branch) and backport to v0.26. Can you change the base branch? You probably need to start a new PR, I'm not too sure on how GH works with these kind of changes.
Also I was thinking in putting the instructions manually, but having the rake task is 👌🏽.
Actually this is complementary to #10120 .
In other words, if we just keep the meta tag, the search engines may still crawl those pages. Using robots.txt we tell the search engines that /profile or /search are "off limits" |
I have to admit that in my head these were interchangeable, and the main difference was if you had direct access to the application/HTML/views vs being able to just add/change a TXT file in the server. 🤷🏽 In our case, I think that both of these cases are good: this is more "hard" against the anti-spam measures, but as its actually a manual task that need to be run, and it could be missed by implementers when updating, the change from #10120 is like a safety net just in case. Thanks for the explanation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some suggestions before merging this one
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
…nto feature/add-robots-txt
@andreslucena let me know if there are any improvements to be done, or is a good to go. |
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll accept the changes so we don't break the generator CI and we can merge this bad boy
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Merging even though we have some failing specs, as they're expected |
* develop: (30 commits) Add `process-content` to erb-lint's deprecated classes (#11762) Add possibility of overriding the tailwind.config.js (#11763) Ask old password when changing email or password (#11737) Add Projects (Budgets) to filtered search (#11740) Fix missing results on Geocoded when search without diacritics (#11761) Add robots.txt instructions (#11693) Add missing activerecord budget locales for search (#11766) Improve design of Admin's Sidebar pages (#11759) Show small static map on admin's meetings index with big screens (#11715) Remove "Manage" button when there's a Sidebar (#11717) Fix admin breadcrumb in Process (#11757) Apply new rubocop rules on erb - Layout/MultilineMethodCallIndentation (#11756) Remove xlarge-* references from admin forms (#11712) Apply new rubocop rules on erb - Argument identation (#11707) Update HERE API autocomplete (#11507) Admin redesign proposal issues (#11668) Redesign: responsive links on cards (#11538) Refactor CI pipelines (#11196) Update postcss and graphql to latest versions (#11733) Fix develop pipeline (#11750) ...
@alecslupu Is is by design that every time I want to create a test app or development app, I get this conflict that I need to choose an option for:
We can also see this same in the CI runs: |
@ahukkanen this was initially designed to be appended to the existing file, but @andreslucena requested something else. i can patch it if @andreslucena agrees. Please see for additional details #11693 (comment) |
OK, I personally find it cumbersome that I have to manually agree on the rewrite of this file during the application generation. It makes total sense when we are modifying an existing application to have the user to confirm the change but when generating new applications, it just adds one extra step. Since it takes a while to generate the application, I generally start it and go to get coffee or something while I'm waiting for the application to be generated. Now I had to find out that it wasn't actually generated because it was stuck waiting for user input. |
I agree, that's a bug. For new apps this should be override without asking for confirmation. I didn't check that out until today and didn't have time to make the PR yet. |
Just to be clear:
|
🎩 What? Why?
In this PR we add some
robots.txt
ruleset, that would prevent search engine crawling certain pages from the platform ( search and profiles). as requested here📌 Related Issues
Link your PR to an issue
Testing
bundle exec rails decidim:robots:replace
📷 Screenshots