Update HERE API autocomplete

[sinaeftekhar]

Current version of api being used by decidim(6.2) is going to be deprecated soon(December 31st, 2023 according to their website). Already new api keys wont be supported for the older versions.

📌 Related Issues

Link your PR to an issue

• Fixes Problem when adding new meeting  #9388
• Fixes here.com API deprecated, new API keys do not work with 6.2 #11466

♥️ Thank you!

[alecslupu]

@sinaeftekhar Can you take care of the failing specs?

[ahukkanen]

Note that we also need to change the format here:

decidim/decidim-core/app/packs/src/decidim/geocoding/provider/here.js

Lines 15 to 21 in 9ccf9a5

	["street", "houseNumber"],
	"district",
	"city",
	"county",
	"state",
	"country"
	];

Some of the keys in the format have changed (review them):
https://developer.here.com/documentation/geocoding-search-api/api-reference-swagger.html

[andreslucena]

@sinaeftekhar whenever you have the time, can you check this out? As its an API deprecation, we want to add this to v0.28 and (probably) also backport this so its available to older versions.

Don't hesitate in letting us know if you don't have the time as we can retake this with the Decidim Association resources. Thanks!

[sinaeftekhar]

Dear @andreslucena
Sorry for the delay.
I've fixed the failing tests(the current failing test looks like a flaky/irrelevant to this PR).

[alecslupu]

I have created a new application in platform.here.com, and tried the API key in a Decidim / develop branch. Using that application, I got an error while using the key.

Switching to this branch, using the same config I could load the map and I was able to partially geolocate my address from admin.

There is a problem with the geolocation part, and that is the Address dropdown is not always being shown, especially when searching with missing diacritics. (extracted to #11760)

When searching for Strada Înving , the request and dropdown works as expected :

API Request is :

GET | https://autocomplete.search.hereapi.com/v1/autocomplete?apiKey=MY_API_KEY&q=Strada Înving&lang=en
returned:

Api response

``` { "items":[ { "title":"Romania, Bucharest, Strada Învingătorilor", "id":"here:af:street:AyzaPMHKHgM.Sj9jm-wB7C", "language":"en", "resultType":"street", "address":{ "label":"Strada Învingătorilor, Bucharest, Romania", "countryCode":"ROU", "countryName":"Romania", "county":"Bucharest", "city":"Bucharest", "district":"Sectorul 3", "street":"Strada Învingătorilor" }, "highlights":{ "title":[ { "start":20, "end":33 } ], "address":{ "label":[ { "start":0, "end":13 } ], "street":[ { "start":0, "end":13 } ] } } }, { "title":"Romania, Bragadiru, Strada Învingătorilor", "id":"here:af:street:FdoEZ.A-bTJ8QWsaXOuZSC", "language":"en", "resultType":"street", "address":{ "label":"Strada Învingătorilor, 077025 Bragadiru, Romania", "countryCode":"ROU", "countryName":"Romania", "county":"Ilfov", "city":"Bragadiru", "district":"Bragadiru", "street":"Strada Învingătorilor", "postalCode":"077025" }, "highlights":{ "title":[ { "start":20, "end":33 } ], "address":{ "label":[ { "start":0, "end":13 } ], "street":[ { "start":0, "end":13 } ] } } }, { "title":"Romania, Glina, Strada Învingătorilor", "id":"here:af:street:ACyLZwPy4O-h6CixNY8.LA", "language":"en", "resultType":"street", "address":{ "label":"Strada Învingătorilor, 077105 Glina, Romania", "countryCode":"ROU", "countryName":"Romania", "county":"Ilfov", "city":"Glina", "street":"Strada Învingătorilor", "postalCode":"077105" }, "highlights":{ "title":[ { "start":16, "end":29 } ], "address":{ "label":[ { "start":0, "end":13 } ], "street":[ { "start":0, "end":13 } ] } } } ] } ```

This does not work:
I am searching for Strada Inving ( mind the Capital i )

GET | https://autocomplete.search.hereapi.com/v1/autocomplete?apiKey=MY_API_KEY&q=Strada Inving&lang=en

Api response

``` { "items":[ { "title":"Romania, Bucharest, Strada Învingătorilor", "id":"here:af:street:AyzaPMHKHgM.Sj9jm-wB7C", "language":"en", "resultType":"street", "address":{ "label":"Strada Învingătorilor, Bucharest, Romania", "countryCode":"ROU", "countryName":"Romania", "county":"Bucharest", "city":"Bucharest", "district":"Sectorul 3", "street":"Strada Învingătorilor" }, "highlights":{ "title":[ { "start":20, "end":33 } ], "address":{ "label":[ { "start":0, "end":13 } ], "street":[ { "start":0, "end":13 } ] } } }, { "title":"Romania, Bragadiru, Strada Învingătorilor", "id":"here:af:street:FdoEZ.A-bTJ8QWsaXOuZSC", "language":"en", "resultType":"street", "address":{ "label":"Strada Învingătorilor, 077025 Bragadiru, Romania", "countryCode":"ROU", "countryName":"Romania", "county":"Ilfov", "city":"Bragadiru", "district":"Bragadiru", "street":"Strada Învingătorilor", "postalCode":"077025" }, "highlights":{ "title":[ { "start":20, "end":33 } ], "address":{ "label":[ { "start":0, "end":13 } ], "street":[ { "start":0, "end":13 } ] } } }, { "title":"Romania, Glina, Strada Învingătorilor", "id":"here:af:street:ACyLZwPy4O-h6CixNY8.LA", "language":"en", "resultType":"street", "address":{ "label":"Strada Învingătorilor, 077105 Glina, Romania", "countryCode":"ROU", "countryName":"Romania", "county":"Ilfov", "city":"Glina", "street":"Strada Învingătorilor", "postalCode":"077105" }, "highlights":{ "title":[ { "start":16, "end":29 } ], "address":{ "label":[ { "start":0, "end":13 } ], "street":[ { "start":0, "end":13 } ] } } } ] } ```

Some other addresses that do not work if there is no :

• Piața Alba Iulia / Piata Alba Iulia
• Splaiul Independenței, Bucharest, Bucharest / Splaiul Independentei, Bucharest, Bucharest
• Sebeș, Alba / Sebes, Alba
• Stenbäckinkatu 24, Taka-Töölö, Helsinki, Uusimaa, South Finland ( searched as Stenbackinkatu 24)
• Veneentekijäntie 4, Lauttasaari, Helsinki, Uusimaa, South Finland ( searched as Veneentekijantie 4)

[alecslupu]

LGTM.
the other issue i was commented about was fixed in a separate PR.

[andreslucena]

I've checked it out locally and it works. I labeled as type: fix so we can backport it.

[ahukkanen]

The label fix (mentioned above) wasn't done in this so it means the country name won't show up in the results.